MySQL forge _alter_table() implementation differs from MSSQL, SQLSRV, PDO, etc. #1005

Radio · 2012-01-31T15:07:51Z

CI_DB_mysql_forge::_alter_table() implementation differs from other drivers. It takes $fields array instead of splitted fild data like other drivers.

MySQL:
function _alter_table($alter_type, $table, $fields, $after_field = '')

MSSQL:
function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')

Shouldn't all forges have same interface?

- PDO subdrivers are isolated from each other now. - Added compatibility for pretty much all of the features, for every DB platform. - Unified the way that stuff works in general. - Fixes issue #1005.

- PDO subdrivers are isolated from each other now. - Added compatibility for pretty much all of the features, for every DB platform. - Unified the way that stuff works in general. - Fixes issue bcit-ci#1005.

narfbg added a commit that referenced this issue Nov 5, 2012

Refactored DB Forge

a287a34

- PDO subdrivers are isolated from each other now. - Added compatibility for pretty much all of the features, for every DB platform. - Unified the way that stuff works in general. - Fixes issue #1005.

narfbg closed this as completed Nov 5, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MySQL forge _alter_table() implementation differs from MSSQL, SQLSRV, PDO, etc. #1005

MySQL forge _alter_table() implementation differs from MSSQL, SQLSRV, PDO, etc. #1005

Radio commented Jan 31, 2012

MySQL forge _alter_table() implementation differs from MSSQL, SQLSRV, PDO, etc. #1005

MySQL forge _alter_table() implementation differs from MSSQL, SQLSRV, PDO, etc. #1005

Comments

Radio commented Jan 31, 2012