MySQL forge _alter_table() implementation differs from MSSQL, SQLSRV, PDO, etc. #1005

Closed
Radio opened this Issue Jan 31, 2012 · 0 comments

Comments

Projects
None yet
2 participants

Radio commented Jan 31, 2012

CI_DB_mysql_forge::_alter_table() implementation differs from other drivers. It takes $fields array instead of splitted fild data like other drivers.

MySQL:
function _alter_table($alter_type, $table, $fields, $after_field = '')

MSSQL:
function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')

Shouldn't all forges have same interface?

@narfbg narfbg added a commit that referenced this issue Nov 5, 2012

@narfbg narfbg Refactored DB Forge
- PDO subdrivers are isolated from each other now.
- Added compatibility for pretty much all of the features, for every DB platform.
- Unified the way that stuff works in general.
- Fixes issue #1005.
a287a34

narfbg closed this Nov 5, 2012

@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this issue Jun 29, 2013

@narfbg narfbg Refactored DB Forge
- PDO subdrivers are isolated from each other now.
- Added compatibility for pretty much all of the features, for every DB platform.
- Unified the way that stuff works in general.
- Fixes issue #1005.
ba11077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment