Documentation for is_referral() #1255

Closed
pleaseremove opened this Issue Apr 12, 2012 · 1 comment

2 participants

@pleaseremove

Currently the documentation states "Returns TRUE/FALSE (boolean) if the user agent was referred from another site" however this is not what the function does. The function doesn't check the if the refferer is for the current site and simply returns true if one is set (which it will be for all links within a site). Either the documentation needs updating or this function needs to be updated to do as described.

@narfbg

I'd consider it a bug.

At the very least - everybody can check if the value exists with ! empty($_SERVER['HTTP_REFERER']), so the method should do more than that.

@narfbg narfbg added a commit that closed this issue Oct 24, 2012
@narfbg narfbg Fix #1255 a0836b9
@narfbg narfbg closed this in a0836b9 Oct 24, 2012
@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this issue Jun 29, 2013
@narfbg narfbg Fix #1255 196e80f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment