Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis session driver does not support TLS connections #5982

Closed
Ddog800 opened this issue Aug 30, 2020 · 1 comment
Closed

Redis session driver does not support TLS connections #5982

Ddog800 opened this issue Aug 30, 2020 · 1 comment

Comments

@Ddog800
Copy link

Ddog800 commented Aug 30, 2020

TLS connections for Redis are often required for compliance reasons (as I'm currently dealing with myself). While the underlying phpredis extension does support TLS connections by including tls:// in the host string, it appears that the CI Redis session driver does not properly parse TLS connection strings when input into the application session config, causing the app to bomb.

After a bit of testing, this appears to be resolvable with a slight tweak to the Regex matching on the value of $this->_config['save_path'] in the Redis session driver library constructor to ensure that tls:// is matched and included in the first capture group. That will then allow a full host string of, i.e., tls://myrediscache.amazonaws.com to be passed along to the underlying phpredis functions.

@Ddog800
Copy link
Author

Ddog800 commented Aug 30, 2020

Opened PR #5983 to implement this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants