Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL prefix and suffix were not being applied to the link for page 1 #1414

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions system/libraries/Pagination.php
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,7 @@ public function create_links()
}
else
{
$n = ($n == '') ? '' : $this->prefix.$n.$this->suffix;

$n = $this->prefix.$i.$this->suffix;
$output .= $this->num_tag_open.'<a '.$this->anchor_class.'href="'.$this->base_url.$n.'">'.$loop.'</a>'.$this->num_tag_close;
}
}
Expand Down
2 changes: 1 addition & 1 deletion user_guide_src/source/general/styleguide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ whether introduced by the developer, user, or an FTP application, can
cause unwanted output, PHP errors, or if the latter are suppressed,
blank pages. For this reason, all PHP files should **OMIT** the closing
PHP tag, and instead use a comment block to mark the end of file and
it's location relative to the application root. This allows you to still
its location relative to the application root. This allows you to still
identify a file as being complete and not truncated.

**INCORRECT**::
Expand Down