Fix Flashdata time comparison for PHP 8 #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks same as #6007. |
|
Sorry, didn't notice that. However that PR seems to address multiple things, and the one for the Flash data check isn't quite correct |
narfbg
added a commit
that referenced
this pull request
Feb 4, 2021
narfbg
added a commit
that referenced
this pull request
Feb 4, 2021
Fix Flashdata time comparison for PHP 8
narfbg
added a commit
that referenced
this pull request
Feb 4, 2021
narfbg
added a commit
that referenced
this pull request
Feb 4, 2021
Closed
FireGUI
pushed a commit
to FireGUI/firegui_client_developers
that referenced
this pull request
Dec 7, 2021
FireGUI
pushed a commit
to FireGUI/firegui_client_developers
that referenced
this pull request
Dec 17, 2021
|
So, how to fix it ? |
|
Yes, why you fix it? |
|
This is an issue in newer version of php . You can fix it by replacing line 420 in system/libraries/Session/Session.php: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 8, string to number comparison works differently (see https://www.php.net/manual/en/migration80.incompatible.php)
This means that Flashdata now no longer clears after each request, and instead persists indefinitely. The author of the Session library helpfully left a comment stating that the string
'old' < time()which under PHP 8 is no longer the case.