Style override for Linear sliders

- Theoretical Inc/Dec override support, but suffers from same bug as for
regular LnF on Inc/Dec buttons
- Fixed #51 (Ableton doesn't auto-add Button into Automation list)
- Fixed problem whereby all buttons were disabled in Read Only mode
(e.g. for loader layout)
- Fixed issue with Inc/Dec drag mode sending double slider drag
notifications

Juce/ScopeSyncShared/Components/BCMSlider.cpp

@@ -287,28 +287,42 @@ bool BCMSlider::isRotary() const
         || getSliderStyle() == RotaryVerticalDrag
         || getSliderStyle() == RotaryHorizontalVerticalDrag;
 }
+
 void BCMSlider::overrideStyle()
 {
-    if (isRotary())
-    {
-        ConfigurationManagerCallout* configurationManagerCallout = new ConfigurationManagerCallout(scopeSyncGUI.getScopeSync(), 550, 60);
-        configurationManagerCallout->setRotaryStyleOverridePanel(styleOverride, getName(), findColour(Slider::rotarySliderFillColourId).toString());
-        configurationManagerCallout->addChangeListener(this);
-        CallOutBox::launchAsynchronously(configurationManagerCallout, getScreenBounds(), nullptr);
-    }
+    String fillColourString;
+
+    if (getSliderStyle() == IncDecButtons)
+        fillColourString = findColour(TextButton::buttonColourId).toString();
+    else if (isRotary())
+        fillColourString = findColour(Slider::rotarySliderFillColourId).toString();
     else
-        BCMParameterWidget::overrideStyle();
+        fillColourString = findColour(Slider::thumbColourId).toString();
+
+    ConfigurationManagerCallout* configurationManagerCallout = new ConfigurationManagerCallout(scopeSyncGUI.getScopeSync(), 550, 60);
+    configurationManagerCallout->setStyleOverridePanel(styleOverride, Ids::slider, getName(), fillColourString);
+    configurationManagerCallout->addChangeListener(this);
+    CallOutBox::launchAsynchronously(configurationManagerCallout, getScreenBounds(), nullptr);
 }
 
 void BCMSlider::applyLookAndFeel(bool noStyleOverride)
 {
     BCMWidget::applyLookAndFeel(noStyleOverride);
 
-    if (!noStyleOverride && isRotary())
+    if (!noStyleOverride)
     {
         String fillColourString = styleOverride.getProperty(Ids::fillColour);
 
         if (fillColourString.isNotEmpty())
-            setColour(Slider::rotarySliderFillColourId, Colour::fromString(fillColourString));        
+        {
+            if (getSliderStyle() == IncDecButtons)
+                setColour(TextButton::buttonColourId, Colour::fromString(fillColourString));
+            else if (isRotary())
+                setColour(Slider::rotarySliderFillColourId, Colour::fromString(fillColourString));
+            else
+                setColour(Slider::thumbColourId, Colour::fromString(fillColourString));
+        }    
     }
+
+    sendLookAndFeelChange();
 }

Juce/ScopeSyncShared/Components/BCMTextButton.cpp

@@ -307,6 +307,9 @@ void BCMTextButton::mouseDown(const MouseEvent& event)
     }
     else
     {
+        if (hasParameter())
+            scopeSync.beginParameterChangeGesture(getParameter());
+
         TextButton::mouseDown(event);
     }
 }
@@ -325,6 +328,9 @@ void BCMTextButton::mouseUp(const MouseEvent& event)
                 scopeSyncGUI.getScopeSync().setParameterFromGUI(*(parameter), valueToSet);
         }
 
+        if (hasParameter())
+            scopeSync.endParameterChangeGesture(getParameter());
+
         TextButton::mouseUp(event);
     }
 }

Juce/ScopeSyncShared/Components/BCMWidget.cpp

@@ -322,7 +322,7 @@ void BCMParameterWidget::editMappedParameter()
 void BCMParameterWidget::overrideStyle()
 {
     ConfigurationManagerCallout* configurationManagerCallout = new ConfigurationManagerCallout(scopeSyncGUI.getScopeSync(), 550, 34);
-    configurationManagerCallout->setStyleOverridePanel(styleOverride, getComponentType(), parentWidget->getName());
+    configurationManagerCallout->setStyleOverridePanel(styleOverride, getComponentType(), parentWidget->getName(), Colours::transparentBlack.toString());
     configurationManagerCallout->addChangeListener(this);
     CallOutBox::launchAsynchronously(configurationManagerCallout, parentWidget->getScreenBounds(), nullptr);
 }

Juce/ScopeSyncShared/Configuration/ConfigurationManager.cpp

@@ -252,23 +252,18 @@ void ConfigurationManagerCallout::setParameterPanel(ValueTree& parameter, BCMPar
     configurationManagerCalloutMain->changePanel(new ParameterPanel(parameter, undoManager, paramType, scopeSync, commandManager, true));
 }
 
-void ConfigurationManagerCallout::setStyleOverridePanel(ValueTree& styleOverride, const Identifier& componentType, const String& componentName)
-{
-    if (!(styleOverride.isValid()))
-         configurationManager.getConfiguration().addStyleOverride(componentType, componentName, styleOverride, -1, &undoManager);
-
-    configurationManagerCalloutMain->changePanel(new StyleOverridePanel(styleOverride, undoManager, scopeSync, commandManager, componentType, true));
-}
-
-void ConfigurationManagerCallout::setRotaryStyleOverridePanel(ValueTree& styleOverride, const String& componentName, const String& fillColour)
+void ConfigurationManagerCallout::setStyleOverridePanel(ValueTree& styleOverride, 
+                                                        const Identifier& componentType, 
+                                                        const String& componentName, 
+                                                        const String& fillColour)
 {
     if (!(styleOverride.isValid()))
     {
-        configurationManager.getConfiguration().addStyleOverride(Ids::slider, componentName, styleOverride, -1, &undoManager);
+        configurationManager.getConfiguration().addStyleOverride(componentType, componentName, styleOverride, -1, &undoManager);
         styleOverride.setProperty(Ids::fillColour, fillColour, &undoManager);
     }
 
-    configurationManagerCalloutMain->changePanel(new RotaryStyleOverridePanel(styleOverride, undoManager, scopeSync, commandManager, true));
+    configurationManagerCalloutMain->changePanel(new StyleOverridePanel(styleOverride, undoManager, scopeSync, commandManager, componentType, true));
 }
 
 void ConfigurationManagerCallout::paint(Graphics& g)

Juce/ScopeSyncShared/Configuration/ConfigurationManager.h

@@ -125,8 +125,7 @@ class ConfigurationManagerCallout : public Component,
 
     void setMappingPanel(ValueTree& mapping, const Identifier& componentType, const String& componentName);
     void setParameterPanel(ValueTree& parameter, BCMParameter::ParameterType paramType);
-    void setStyleOverridePanel(ValueTree& styleOverride, const Identifier& componentType, const String& componentName);
-    void setRotaryStyleOverridePanel(ValueTree& styleOverride, const String& componentName, const String& fillColour);
+    void setStyleOverridePanel(ValueTree& styleOverride, const Identifier& componentType, const String& componentName, const String& fillColour);
 
 private:
     ScopeSync&                 scopeSync;

Juce/ScopeSyncShared/Configuration/ConfigurationPanel.cpp

@@ -550,6 +550,7 @@ StyleOverridePanel::StyleOverridePanel(ValueTree& mapping, UndoManager& um,
 
 void StyleOverridePanel::rebuildProperties()
 {
+    String componentTypeName = Configuration::getComponentTypeName(componentType);
     PropertyListBuilder props;
 
     props.clear();
@@ -564,8 +565,6 @@ void StyleOverridePanel::rebuildProperties()
 
         componentNames.insert(0, "- No Component -");
         componentValues.insert(0, String::empty);
-
-        String componentTypeName = Configuration::getComponentTypeName(componentType);
 
         props.add(new ChoicePropertyComponent(valueTree.getPropertyAsValue(Ids::name, &undoManager), componentTypeName + " Name", componentNames, componentValues), "Choose the "+ componentTypeName + " to override style for");
     }
@@ -583,26 +582,9 @@ void StyleOverridePanel::rebuildProperties()
     lookAndFeelValues.insert(0, String::empty);
 
     props.add(new ChoicePropertyComponent(valueTree.getPropertyAsValue(Ids::lookAndFeelId, &undoManager), "LookAndFeel", lookAndFeelIds, lookAndFeelValues), "Choose the LookAndFeel to use");
-
+
+    if (componentType == Ids::slider)
+        props.add(new ComponentBackgroundColourProperty(valueTree.getPropertyAsValue(Ids::fillColour, &undoManager), "Fill Colour"), "Choose the Colour to fill this " + componentTypeName + " with");
+
     propertyPanel.addProperties(props.components);
 }
-
-/* =========================================================================
- * RotaryStyleOverridePanel
- */
-RotaryStyleOverridePanel::RotaryStyleOverridePanel(ValueTree& mapping, UndoManager& um, 
-                                       ScopeSync& ss, ApplicationCommandManager* acm, 
-                                       bool calloutView)
-    : StyleOverridePanel(mapping, um, ss, acm, Ids::slider, calloutView)
-{
-    rebuildProperties();
-}
-
-void RotaryStyleOverridePanel::rebuildProperties()
-{
-    PropertyListBuilder props;
-
-    props.clear();
-    props.add(new ComponentBackgroundColourProperty(valueTree.getPropertyAsValue(Ids::fillColour, &undoManager), "Fill Colour"), "Choose the Colour to fill this Rotary Slider with");
-    propertyPanel.addProperties(props.components);
-}

Juce/ScopeSyncShared/Core/ScopeSync.cpp

@@ -207,8 +207,12 @@ void ScopeSync::beginParameterChangeGesture(BCMParameter* parameter)
     {
 #ifndef __DLL_EFFECT__
         int hostIdx = parameter->getHostIdx();
-        pluginProcessor->beginParameterChangeGesture(hostIdx);
-        changingParams.setBit(hostIdx);
+
+        if (!changingParams[hostIdx])
+        {
+            pluginProcessor->beginParameterChangeGesture(hostIdx);
+            changingParams.setBit(hostIdx);
+        }
 #else
         parameter->setAffectedByUI(true);
 #endif // __DLL_EFFECT__
@@ -221,8 +225,12 @@ void ScopeSync::endParameterChangeGesture(BCMParameter* parameter)
     {
 #ifndef __DLL_EFFECT__
         int hostIdx = parameter->getHostIdx();
-        pluginProcessor->endParameterChangeGesture(hostIdx); 
-        changingParams.clearBit(hostIdx);
+
+        if (changingParams[hostIdx])
+        {
+            pluginProcessor->endParameterChangeGesture(hostIdx); 
+            changingParams.clearBit(hostIdx);
+        }
 #else
         parameter->setAffectedByUI(false);
 #endif // __DLL_EFFECT__

Juce/ScopeSyncShared/Core/ScopeSyncGUI.cpp

@@ -426,6 +426,17 @@ void ScopeSyncGUI::getAllCommands(Array<CommandID>& commands)
 
         commands.addArray (ids, numElementsInArray(ids));
     }
+    else
+    {
+        const CommandID ids[] = { CommandIDs::snapshot,
+                                  CommandIDs::showUserSettings,
+                                  CommandIDs::chooseConfiguration
+                                };
+
+        commands.addArray (ids, numElementsInArray(ids));
+    }
+
+
 }
 
 void ScopeSyncGUI::getCommandInfo(CommandID commandID, ApplicationCommandInfo& result)