Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(istanbul-reports)!: lcov reports now use relative paths #168

Merged
merged 3 commits into from
Nov 28, 2019

Conversation

bcoe
Copy link
Owner

@bcoe bcoe commented Nov 28, 2019

The next major release of nyc uses updated Istanbul APIs, we should move to them too.

The feature I'm most excited about is support for relative paths in lcov reports (which is required for merging reports).

CC: @coreyfarrell, @j03m

@coveralls
Copy link

coveralls commented Nov 28, 2019

Pull Request Test Coverage Report for Build 505

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 94.1%

Totals Coverage Status
Change from base Build 500: 0.02%
Covered Lines: 558
Relevant Lines: 581

💛 - Coveralls

Copy link
Collaborator

@j03m j03m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I trust the alpha is stable enough?

@coreyfarrell
Copy link

This looks good to me. I trust the alpha is stable enough?

The istanbul stuff is inches away from final, I don't expect any significant changes. Honestly at this point not sure why I labeled the releases alpha instead of beta.

@bcoe bcoe merged commit 35d9338 into master Nov 28, 2019
@bcoe bcoe deleted the reporting-update branch November 28, 2019 21:06
@release-please release-please bot mentioned this pull request Nov 28, 2019
@SimenB SimenB mentioned this pull request Dec 4, 2019
@bcoe bcoe mentioned this pull request Feb 2, 2021
mcknasty pushed a commit to mcknasty/c8 that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants