Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clean command #26

Closed
wants to merge 1 commit into from
Closed

feat: add clean command #26

wants to merge 1 commit into from

Conversation

bcoe
Copy link
Owner

@bcoe bcoe commented Sep 13, 2018

Adds clean command, which allows the deletion of the temporary directory to be skipped between runs of c8.

This is useful for our own test coverage, each run of c8 was stepping on the other's toes.

@bcoe bcoe requested a review from JaKXz September 13, 2018 02:01
@bcoe
Copy link
Owner Author

bcoe commented Sep 13, 2018

CC: @laggingreflex

@coveralls
Copy link

Pull Request Test Coverage Report for Build 26

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 90.778%

Totals Coverage Status
Change from base Build 24: -1.6%
Covered Lines: 206
Relevant Lines: 210

💛 - Coveralls

Copy link

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good but I'm not sure I have the cycles to review this fully, sorry @bcoe

lib | 96.41 | 65.38 | 100 | 96.41 | |
parse-args.js | 97.47 | 44.44 | 100 | 97.47 | 55,56 |
report.js | 95.45 | 76.47 | 100 | 95.45 | 51,52,53,54 |
test/fixtures | 95.16 | 83.33 | 0 | 95.16 | |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be instrumented?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this allows me to test that various edge-cases are covered, e.g., subprocesses, JavaScript programs that exit in a weird way.

Once the actual coverage is output for the application itself, everything in test is removed from the report.

@bcoe bcoe closed this Sep 13, 2018
@bcoe bcoe deleted the clean branch September 13, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants