Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Derived Configuration Report #516

Closed
wants to merge 1 commit into from

Conversation

mcknasty
Copy link
Contributor

@mcknasty mcknasty commented Jan 17, 2024

Pull Request 516

commit 2b0e3addd10486bfee15d7741607a1ba038453f1
Author: The Nasty tmckeown@gmail.com
Date: Wed Jan 17 19:49:43 2024 -0500

    Print Derived Configuration Report

    feat: print derived config variables
    feat: print derived config variables in json
    test: 12 new unit tests to support features
    test: 1 skipped unit test for discovered bug in yargs with reports param

Following the Contributions Recommendations here.

  1. Make sure you have installed the latest version of Node.js
  2. Fork this project on GitHub and clone your fork locally
  3. Create local branches to work within. These should also be created directly from the main branch. Local Fork here.
  4. Make your changes.
  5. Run tests to make sure all is okay (everything should pass except the snapshot).
    1. A complete log of initial test results.
    2. As instructed, ignore snapshot failures. 1 pending
    3. 105 passing in 57 seconds
  6. Now update the snapshot.
    1. A complete log of snapshot test results.
    2. 107 passing in 56 seconds
  7. If all is passing, commit your changes. The log of the commit can be found here.
  8. As a best practice, once you have committed your changes, it is a good idea to use git rebase (not git merge) to synchronize your work with the main repository.
  9. Run tests again to make sure all is okay.
    1. A complete log of the final test results.
    2. 107 passing in 1 minutes
  10. Push
  11. Open the pull request, see details in the template.
  12. Make any necessary changes after review.

Unit Tests Results

Test Type PASS Tests Passed Tests Failed Time
Initial Test 105 passing 2 failing 57 seconds
Snapshot Test ✔️ 107 passing 1 pending 56 seconds
Final Test ✔️ 107 passing 1 pending 1 minutes

Node Version Testing Matrix

Node Version PASS Tests Passed Tests Failed Time
14.21.3 97 passing 10 failing 1 minutes
16.20.2 ✔️ 107 passing 1 pending 1 minutes
18.19.0 ✔️ 107 passing 1 pending 1 minutes
20.11.0 ✔️ 107 passing 1 pending 1 minutes

@mcknasty mcknasty force-pushed the print-config branch 2 times, most recently from a3da7f7 to 2b0e3ad Compare January 18, 2024 00:50
@mcknasty mcknasty mentioned this pull request Jan 18, 2024
12 tasks
@mcknasty mcknasty force-pushed the print-config branch 2 times, most recently from ad02da7 to ec4111a Compare January 18, 2024 01:27
mcknasty added a commit to mcknasty/c8 that referenced this pull request Jan 18, 2024
feat: print derived config variables
feat: print derived config variables in json
test: 12 new unit tests to support features
test: 1 skipped unit test for discovered bug in yargs with reports param
mcknasty added a commit to mcknasty/c8 that referenced this pull request Jan 18, 2024
feat: print derived config variables
feat: print derived config variables in json
test: 12 new unit tests to support features
test: 1 skipped unit test for discovered bug in yargs with reports param
mcknasty added a commit to mcknasty/c8 that referenced this pull request Jan 18, 2024
feat: print derived config variables
feat: print derived config variables in json
test: 12 new unit tests to support features
test: 1 skipped unit test for discovered bug in yargs with reports param
@mcknasty mcknasty force-pushed the print-config branch 2 times, most recently from cdd98c2 to b9e5c9e Compare January 18, 2024 01:52
mcknasty added a commit to mcknasty/c8 that referenced this pull request Jan 18, 2024
feat: print derived config variables
feat: print derived config variables in json
test: 12 new unit tests to support features
test: 1 skipped unit test for discovered bug in yargs with reports param
mcknasty added a commit to mcknasty/c8 that referenced this pull request Jan 18, 2024
feat: print derived config variables
feat: print derived config variables in json
test: 12 new unit tests to support features
test: 1 skipped unit test for discovered bug in yargs with reports param
mcknasty added a commit to mcknasty/c8 that referenced this pull request Jan 18, 2024
feat: print derived config variables
feat: print derived config variables in json
test: 12 new unit tests to support features
test: 1 skipped unit test for discovered bug in yargs with reports param
mcknasty added a commit to mcknasty/c8 that referenced this pull request Jan 18, 2024
feat: print derived config variables
feat: print derived config variables in json
test: 12 new unit tests to support features
test: 1 skipped unit test for discovered bug in yargs with reports param
mcknasty added a commit to mcknasty/c8 that referenced this pull request Jan 18, 2024
feat: print derived config variables
feat: print derived config variables in json
test: 12 new unit tests to support features
test: 1 skipped unit test for discovered bug in yargs with reports param
@mcknasty mcknasty force-pushed the print-config branch 7 times, most recently from cf83b69 to a31ffc3 Compare January 19, 2024 23:45
mcknasty added a commit to mcknasty/c8 that referenced this pull request Jan 20, 2024
feat: print derived config variables
feat: print derived config variables in json
test: 12 new unit tests to support features
test: 1 skipped unit test for discovered bug in yargs with reports param
feat: print derived config variables
feat: print derived config variables in json
test: 12 new unit tests to support features
test: 1 skipped unit test for discovered bug in yargs with reports param
@bcoe
Copy link
Owner

bcoe commented Jun 9, 2024

@mcknasty it's mostly my fault for not being more engaged on this repo, but I think I need to declare bankruptcy on some of the inflight PRs.

If you're still feeling passionate about some of these changes (some were pretty cool IMO, like printing derived configuration), mind reopening on at a time, with a tracking issue that describes the functionality you'd like to see.

Thank you for the work you have done on this repo 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants