Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed [warning] (chain) unknown version bits in block #1029

Merged
merged 1 commit into from Aug 13, 2021

Conversation

pradyuman-verma
Copy link
Contributor

@pradyuman-verma pradyuman-verma commented Aug 12, 2021

Resolves #1028

  • As miners are using OvertAsic boost to produce blocks with random version numbers, which adds more false positives to the BIP91 signalling.
  • This removes the warning which is haunting users for a long time.

@codecov-commenter
Copy link

Codecov Report

Merging #1029 (8044bc2) into master (950e30c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   62.53%   62.53%   -0.01%     
==========================================
  Files         156      156              
  Lines       26085    26075      -10     
==========================================
- Hits        16313    16305       -8     
+ Misses       9772     9770       -2     
Impacted Files Coverage Δ
lib/blockchain/chain.js 68.66% <ø> (+0.07%) ⬆️
lib/blockchain/chainentry.js 79.48% <ø> (-1.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950e30c...8044bc2. Read the comment docs.

@pinheadmz
Copy link
Member

Yes sadly agree with this. See also btcsuite/btcd#1463 and bitcoin/bitcoin#15471

p.s. @pradyuman-verma did you mean BIP9 in your comment?

Copy link
Member

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8044bc2

Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK 8044bc25ef5ead024fbdb2fa0ec95303a298f659
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmEWi5IACgkQ5+KYS2KJ
yTqD+xAA14EvsrshvgWkbaOlrhs0OSCdp+RHmXwh9PqWkc4uhNesfGY9sSUyYzfr
Nf1PTnKyvgAS26rP8LSPjBJcxbMgFgKC+HDUwFpFAG4KPmi0L2jGiTLNurfZo5CI
DVkhc3GKssP6wRn+ti+K/PQgvvXNwZr8OjVuMDMFwMchcRcr42pXnEUUhTXeOWv1
AuOiU3pac2ASMUib67hBOMOp4l2+OPzm3am+eo/FMCfAJrMBb+OrsqndFRiYweYy
HVQ+fWvVIV7ZOeQS2+U28hjlcXT06kxJYBcf6o5YtJ5pnOQOk6c+JuAbHUyIo6a6
3epsgwP01yeGQclsoQ+f7XvlI8Ek+8NWZj8mhy+TZHy4H8WHsOlZjxMrPqLxBW+l
XRMMTJAbkN49AAoSGvT3uG3ZCI7r43k5zCX1LpZTc1zlykQhKy+918Y1H8XS5zEZ
frJs1eNSrbbSLtbLrgiW+S1WlpKYPGCbIoCJXTO1cZpKS5sqefV8Upe9AIbtVl9u
pbUt+vb2Ki+M6osMgNHpPmYyogAyy25ZxQpEOi5hZ1YhYmJI/hHqfkrXKaDFpvDo
OHany2XDUJ1jsYB4orziLheRURby5D0WXjSUHnoalv51TaAME/aPCEmPEpMfPxhy
mChmnIEby+Nhe6BdpUUE1PXbvNC/rGs/QtcrrxIW3oU/0IoFKOk=
=7msD
-----END PGP SIGNATURE-----

pinheadmz's public key is on keybase

@pinheadmz pinheadmz merged commit cae1bb9 into bcoin-org:master Aug 13, 2021
@pradyuman-verma pradyuman-verma deleted the removes-warning branch June 25, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[warning] (chain) Unknown version bits in block
3 participants