update to minimum fee rate #1036
Conversation
lib/protocol/networks.js
Outdated
| @@ -477,7 +477,7 @@ main.minRelay = 1000; | |||
| * @default | |||
| */ | |||
|
|
|||
| main.feeRate = 100000; | |||
| main.feeRate = 1000; | |||
There was a problem hiding this comment.
I agree we need to lower it from 100 sat / kB but I think 1 sat / kB might be too low. It's a hard thing to set because we don't want users over paying but also (without RBF in bcoin) we don't want users TXs getting stuck for a week. Bitcoin Core used to have a fallback fee of 0.0002 BTC/kB (2000 sat/kB). They have removed that hard coded value and require users to set it themselves.
What do you think about setting this to 2000 or 5000 instead?
There was a problem hiding this comment.
It is 1sat/byte, formerly it was 100sat/byte, but yeah, 1sat/byte is relatively low.
5sat/byte fits the curve.
There was a problem hiding this comment.
sorry lol, fee rate units are the worst! Ok I am going to change this value to 5000 then and merge. Thank you!
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
=======================================
Coverage 65.40% 65.40%
=======================================
Files 156 156
Lines 26075 26075
=======================================
Hits 17055 17055
Misses 9020 9020
Continue to review full report at Codecov.
|
Resolves #1017
This PR tries to resolve the hard minimum fee rate in
bcoin, previously this rate was100 sat/kb(unchanged since 2017 before segwit), but after segwit, this has to update as for a segwit transaction inSPV mode, which doesn't have any fee estimation method. Therefore SPV mode uses the hardcoded minimum fee rate (100 sat/kbyte), which is too much for asegwit transaction.