Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: add "accountPath" attribute to handle edges cases with watch-only accountKeys #689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wallet: add "accountPath" attribute to handle edges cases with watch-only accountKeys #689

wants to merge 1 commit into from

Commits on Feb 5, 2019

  1. wallet: add "accountPath" to all responses dealing with "accountIndex" 

    Motivation:
In case of watch-only wallets, accountIndex is "arbitrary".
It simply maps to internal walletdb account instead of
BIP44 account path as defined in original accountKey.

It is important to return the actual accountIndex for use-cases
such as hardware-wallets, so clients can easily reproduce the
original path for this account.

To maintain backwards compatbility with existing wallets,
it is easiest to add this as a separate accountPath field
instead of refactoring all the existing uses of accountIndex.
    @BluSyn
    BluSyn committed Feb 5, 2019
    Copy the full SHA
    996e588 View commit details
    Browse the repository at this point in the history