Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct "n is less than 2" warning #27

Merged
merged 2 commits into from
Jan 8, 2019
Merged

correct "n is less than 2" warning #27

merged 2 commits into from
Jan 8, 2019

Conversation

pinheadmz
Copy link
Member

Actual test is assert( n > 1 ...
I was accidentally trying to create a 1-of-1 multisig wallet and got the error n is less than 1 which I thought was funny. Technically the error is that n must be 2 or greater.

@codecov-io
Copy link

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files          14       14           
  Lines        2287     2287           
  Branches      244      244           
=======================================
  Hits         1934     1934           
  Misses        353      353
Impacted Files Coverage Δ
lib/wallet.js 93.59% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917091f...0b7f589. Read the comment docs.

@nodech nodech merged commit febd7fe into master Jan 8, 2019
@nodech nodech deleted the n-lessthan-2 branch August 23, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants