Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROAD_BUILDING bugs #205

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Fix ROAD_BUILDING bugs #205

merged 1 commit into from
Aug 27, 2022

Conversation

bcollazo
Copy link
Owner

@bcollazo bcollazo commented Aug 27, 2022

Code was allowing to use ROAD_BUILDING card only if user had money for roads. Should allow to use even if no money for roads. It was also not cleaning correctly the state.free_roads_available state.

@coveralls
Copy link

coveralls commented Aug 27, 2022

Pull Request Test Coverage Report for Build 2939932070

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 95.594%

Totals Coverage Status
Change from base Build 2939862600: 0.07%
Covered Lines: 1280
Relevant Lines: 1339

💛 - Coveralls

@bcollazo bcollazo temporarily deployed to catanatron-feature-trad-lqzqio August 27, 2022 16:13 Inactive
@bcollazo bcollazo temporarily deployed to catanatron-feature-trad-lqzqio August 27, 2022 16:32 Inactive
@bcollazo bcollazo changed the title Fix free_roads_available bug Fix ROAD_BUILDING bugs Aug 27, 2022
@bcollazo bcollazo temporarily deployed to catanatron-feature-trad-lqzqio August 27, 2022 16:37 Inactive
@bcollazo bcollazo merged commit 4b05b1c into master Aug 27, 2022
@bcollazo bcollazo deleted the feature/trading branch August 27, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants