Implements minor readability changes. #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for catanatron-staging pending review.Visit the deploys page to approve it
|
|
Looks good, can you update with master? |
tonypr
force-pushed
the
minor_changes_2
branch
from
ccdba1d
to
8e40c85
Compare
Pull Request Test Coverage Report for Build 7066438141
💛 - Coveralls |
tonypr
force-pushed
the
minor_changes_2
branch
2 times, most recently
from
e80b305
to
3121091
Compare
tonypr
force-pushed
the
minor_changes_2
branch
from
4c8335c
to
9aa9025
Compare
|
Great! Looks like that worked! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to do two things:
build_road.bfstodfs. Since it visits nodes in LIFO order. They have the same performance in this case I think so no need to change any actual code.Tested with:
coverage run --source=catanatron -m pytest tests/