Move fade more local to avoid fading twice

bdach · Jan 25, 2024 · d0421fe · d0421fe
1 parent 6070eac
commit d0421fe
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/osu.Game/Skinning/LegacyJudgementPieceOld.cs b/osu.Game/Skinning/LegacyJudgementPieceOld.cs
@@ -44,7 +44,6 @@ public virtual void PlayAnimation()
             const double fade_out_length = 600;
 
             this.FadeInFromZero(fade_in_length);
-            this.Delay(fade_out_delay).FadeOut(fade_out_length);
 
             if (result.IsMiss())
             {
@@ -74,6 +73,8 @@ public virtual void PlayAnimation()
                     this.RotateTo(0);
                     this.RotateTo(rotation, fade_in_length)
                         .Then().RotateTo(rotation * 2, fade_out_delay + fade_out_length - fade_in_length, Easing.In);
+
+                    this.Delay(fade_out_delay).FadeOut(fade_out_length);
                 }
             }
             else
@@ -87,6 +88,8 @@ public virtual void PlayAnimation()
                     // so we need to force the current value to be correct at 1.2 (0.95) then complete the
                     // second half of the transform.
                     .ScaleTo(0.95f).ScaleTo(finalScale, fade_in_length * 0.2f); // t = 1.4
+
+                this.Delay(fade_out_delay).FadeOut(fade_out_length);
             }
         }