New DDS profile for a flaky test #437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcappellari-bdai
requested review from
METEORITENMAX,
jbarry-bdai,
amessing-bdai,
mpickett-bdai,
bhung-bdai and
khughes-bdai
as code owners
khughes-bdai
approved these changes
Jul 26, 2024
| @@ -130,6 +130,8 @@ target_include_directories(test_kinematic_service | |||
| ) | |||
| target_link_libraries(test_kinematic_service spot_api) | |||
|
|
|||
| ament_add_pytest_test(spot_driver_pytest ${CMAKE_CURRENT_SOURCE_DIR} TIMEOUT 900) | |||
There was a problem hiding this comment.
Do we want to go with this approach of 900s for all of the tests or the one below which loops over and gives individual tests targets?
There was a problem hiding this comment.
To be clear I am not leaning one way or the other. Just checking
Pull Request Test Coverage Report for Build 10117260442Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Added in a new DDS profile based off of https://github.com/bdaiinstitute/bdai/pull/6448 to fix a flaky test caused by race conditions in service discovery in FastDDS.
Testing Done
[x] I ran the pytests locally a few times and saw the flaky test pass but unsure how to robustly test it since it usually passes in CI but not always
Please create a checklist of tests you plan to do and check off the ones that have been completed successfully. Ensure that ROS 2 tests use
domain_coordinatorto prevent port conflicts. Further guidance for testing can be found on the ros utilities wiki.