Editor fix #122
Merged
Editor fix #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MonographComponent -> CollectionComponent * get the parent.editor also * adjust other code Signed-off-by: Bruce D'Arcus <bdarcus@gmail.com>
bdarcus
commented
Jul 29, 2023
Closes: #121 Signed-off-by: Bruce D'Arcus <bdarcus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#121 is driving me crazy, but I've at least narrowed the problem to the
suppress_componentmethod, and specifically to the logic for editors.I think fixing this may require reverting an earlier refactor.
The
reference.author()method should only return an author, and the substitution should happen somewhere else, and explicitly.It could be I move
get_author_substitutetoInputReference, which seems the natural place to put it. But that likely means it would be hard-coded?Or maybe not; could return a hash table of the substitution options, and let the processor select the correct one based on the style config?