Don't use defaults in reactor.py as they cause unneeded initializations.

Fix the unittest to not initialize IOLoop's global instance.
bdarnell · Jul 12, 2011 · 3bb589f · 3bb589f
1 parent ec838ed
commit 3bb589f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 14 deletions.
diff --git a/tornado/test/runtests.py b/tornado/test/runtests.py
@@ -14,11 +14,11 @@
     'tornado.test.ioloop_test',
     'tornado.test.iostream_test',
     'tornado.test.process_test',
-    'tornado.test.twistedreactor_test',
     'tornado.test.simple_httpclient_test',
     'tornado.test.stack_context_test',
     'tornado.test.template_test',
     'tornado.test.testing_test',
+    'tornado.test.twistedreactor_test',
     'tornado.test.web_test',
     'tornado.test.wsgi_test',
 ]

diff --git a/tornado/test/twistedreactor_test.py b/tornado/test/twistedreactor_test.py
@@ -23,14 +23,11 @@
 import thread
 import unittest
 
-import tornado.twisted.reactor
-tornado.twisted.reactor.install()
-from twisted.internet import reactor
-
 from twisted.internet.interfaces import IReadDescriptor, IWriteDescriptor
 from twisted.python import log
 from tornado.platform.auto import Waker
 
+from tornado.ioloop import IOLoop
 from tornado.twisted.reactor import TornadoReactor
 from tornado.testing import AsyncTestCase, LogTrapTestCase
 
@@ -40,7 +37,7 @@
 
 class ReactorWhenRunningTest(unittest.TestCase):
     def setUp(self):
-        self._reactor = TornadoReactor()
+        self._reactor = TornadoReactor(IOLoop())
 
     def test_whenRunning(self):
         self._whenRunningCalled = False
@@ -60,7 +57,7 @@ def anotherWhenRunningCallback(self):
 
 class ReactorCallLaterTest(unittest.TestCase):
     def setUp(self):
-        self._reactor = TornadoReactor()
+        self._reactor = TornadoReactor(IOLoop())
 
     def test_callLater(self):
         self._laterCalled = False
@@ -80,7 +77,7 @@ def callLaterCallback(self):
 
 class ReactorTwoCallLaterTest(unittest.TestCase):
     def setUp(self):
-        self._reactor = TornadoReactor()
+        self._reactor = TornadoReactor(IOLoop())
 
     def test_callLater(self):
         self._later1Called = False
@@ -110,7 +107,7 @@ def callLaterCallback2(self):
 
 class ReactorCallFromThreadTest(unittest.TestCase):
     def setUp(self):
-        self._reactor = TornadoReactor()
+        self._reactor = TornadoReactor(IOLoop())
         self._mainThread = thread.get_ident()
 
     def _newThreadRun(self, a, b):
@@ -130,7 +127,7 @@ def testCallFromThread(self):
 
 class ReactorCallInThread(unittest.TestCase):
     def setUp(self):
-        self._reactor = TornadoReactor()
+        self._reactor = TornadoReactor(IOLoop())
         self._mainThread = thread.get_ident()
 
     def _fnCalledInThread(self, *args, **kwargs):
@@ -190,7 +187,7 @@ def _set_nonblocking(self, fd):
         fcntl.fcntl(fd, fcntl.F_SETFL, flags | os.O_NONBLOCK)
 
     def setUp(self):
-        self._reactor = TornadoReactor()
+        self._reactor = TornadoReactor(IOLoop())
         r, w = os.pipe()
         self._set_nonblocking(r)
         self._set_nonblocking(w)
@@ -205,7 +202,7 @@ def _testReadWrite(self):
         reads it, check the value and ends the test.
         """
         def checkReadInput(fd):
-            self.assertEqual(fd.read(), 'x')
+            self.assertTrue(fd.read().startswith('x'))
             self._reactor.stop()
         self._reader = Reader(self._p1, checkReadInput)
         self._writer = Writer(self._p2, lambda fd: fd.write('x'))

diff --git a/tornado/twisted/reactor.py b/tornado/twisted/reactor.py
@@ -88,7 +88,9 @@ class TornadoReactor(PosixReactorBase):
     """
     implements(IReactorTime, IReactorFDSet)
 
-    def __init__(self, ioloop=tornado.ioloop.IOLoop.instance()):
+    def __init__(self, ioloop):
+        if not ioloop:
+            ioloop = tornado.ioloop.IOLoop.instance()
         self._ioloop = ioloop
         self._readers = {}
         self._writers = {}
@@ -241,10 +243,12 @@ def mainLoop(self):
         self.running = True
         self._ioloop.start()
 
-def install(ioloop=tornado.ioloop.IOLoop.instance()):
+def install(ioloop=None):
     """
     Install the Tornado reactor.
     """
+    if not ioloop:
+        ioloop = tornado.ioloop.IOLoop.instance()
     reactor = TornadoReactor(ioloop)
     from twisted.internet.main import installReactor
     installReactor(reactor)