Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

fetchAllData sometimes gets into loop #16

Closed
bdefore opened this issue Dec 23, 2015 · 9 comments
Closed

fetchAllData sometimes gets into loop #16

bdefore opened this issue Dec 23, 2015 · 9 comments

Comments

@bdefore
Copy link
Owner

bdefore commented Dec 23, 2015

It has been removed for 2.0.0-beta5 pending resolution of jlongster/react-redux-universal-hot-example#4

@bdefore
Copy link
Owner Author

bdefore commented Dec 29, 2015

Exploring react-fetcher as an alternative on a branch. But it will also need to change when the new React Router API drops: erikras/react-redux-universal-hot-example#531

@tadeuszwojcik
Copy link

Hi, I've spent way to much time choosing starting point for new project and finally settled on your project. Great work!
Is there a chance you'll bring back fetchData, or alternative way of fetching data for server-side rendering in near future? Or perhaps it's outside of scope of that project?
Cheers

@bdefore
Copy link
Owner Author

bdefore commented Jan 12, 2016

@tadeuszwojcik definitely near future. a hook for serverside fetching is a core piece of what universal-redux should provide, and ideally it should also allow custom serverside render hooks in case you want to do roll your own fetching logic (a kind of 'universal rendering middleware'). work on this has been blocked by the changes in updating to react-router 2.0, which are now nearly stable in the 3.x version of UR, and it's there that i intend to look into plugging in either react-fetcher or something like it. whether that makes it back to 2.x depends on if redux-simple-router can support it, which depends on the issue above. at this point i'd recommend going with UR 3.x unless there's an issue with your project code an react-router 2.0-rc4.

@bdefore
Copy link
Owner Author

bdefore commented Jan 12, 2016

I'd like to keep this issue open for mainly for backward compatibility, about returning fetchData to 2.x, and #43 for about new and potentially different ways of solving the same problem.

@tadeuszwojcik
Copy link

cool, thanks for the update!

@bdefore
Copy link
Owner Author

bdefore commented Jan 13, 2016

@tadeuszwojcik Release 3.0.0-rc5 has async-props support. Put a static loadProps function on your views to use. https://github.com/rackt/async-props#usage

@bdefore
Copy link
Owner Author

bdefore commented Jan 20, 2016

3.0.0-rc16 now uses redux-async-connect. More info here #50 (comment)

@shilpan
Copy link

shilpan commented Jan 23, 2016

How do you recommend using it with: http://erikras.github.io/redux-form/#/api/reduxForm?_k=ercae5

@bdefore
Copy link
Owner Author

bdefore commented Jan 24, 2016

@shilpan you should be able to use both the @asyncConnect and @reduxForm decorators on your components.

@bdefore bdefore closed this as completed Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants