Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Compiler warnings #2

Open
pjrobertson opened this Issue Jun 28, 2012 · 5 comments

Comments

Projects
None yet
2 participants

First off - great to see UKKQueue ready for 64 bit (yeah, I'm a bit behind) and using GCD, thanks!

If you turn on the -Wextra compiler warning flag when building VDKQueue, you get a few warnings about semicolons at the end of files (e.g. VDKQueue.m:L54) and about unknown pragmas (e.g. VDKQueue.m:L30,31)

Not a big issue, but would you be able to fix these warnings, just so that things look a little nicer when I build my projects.

Happy to send a pull request if you want

Thanks!

Owner

bdkjones commented Jun 28, 2012

Send a pull request, please. Thanks!

Owner

bdkjones commented Jan 15, 2013

What do you get by turning on Wextra that makes it worthwhile?

I find it generally picks up on code that's perfectly valid, but is
incomplete/redundant.
Often it'll pick up on empty if() bodies which I realise I've just
forgotten to implement, or unused function parameters etc.

It was also really useful for us when we were performing the 64 bit
transition.

All in all, it just keeps our code looking tidier :)

On 15 January 2013 07:59, bdkjones notifications@github.com wrote:

What do you get by turning on Wextra that makes it worthwhile?


Reply to this email directly or view it on GitHubhttps://github.com/bdkjones/VDKQueue/issues/2#issuecomment-12256990.

#3 is merged.

Closed

...actually, not all the warnings are gone :(

I've opened #7 with the last few

@pjrobertson pjrobertson reopened this Jan 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment