Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment variable HOSTNAME used as the sole source of the hostname #28

Closed
ivucica opened this issue Sep 28, 2020 · 0 comments
Closed

Environment variable HOSTNAME used as the sole source of the hostname #28

ivucica opened this issue Sep 28, 2020 · 0 comments

Comments

@ivucica
Copy link
Contributor

ivucica commented Sep 28, 2020

The environment variable HOSTNAME is used as the sole source of the hostname in formatter.go.

It would be useful to consult os.Hostname() as well, in case HOSTNAME is empty, as is the case on a machine I used.

(bash still expands ${HOSTNAME}; however, processes don't see the variable and it doesn't show up in getenv, likely helping the confusion.)
ivucica added a commit to ivucica/bdlm-log that referenced this issue Sep 28, 2020
@ivucica
Populate hostname from the OS, not just the environment.
234a7be 
The environment variable `HOSTNAME` is not necessarily set on a
machine, making a call to `os.Hostname()` a useful replacement.

Fixes bdlm#28.
ivucica added a commit to ivucica/bdlm-log that referenced this issue Sep 28, 2020
@ivucica
Disable hostname resolution in TestEscaping_Error.
0b8cdd1 
The test output does not expect the hostname to be printed; fixing bdlm#28
breaks the test.
@ivucica ivucica mentioned this issue Sep 28, 2020
Merged
5 tasks
ivucica added a commit to ivucica/bdlm-log that referenced this issue Sep 28, 2020
@ivucica
Populate hostname from the OS, not just the environment.
267daeb 
The environment variable `HOSTNAME` is not necessarily set on a
machine, making a call to `os.Hostname()` a useful replacement.

Fixes bdlm#28.
ivucica added a commit to ivucica/bdlm-log that referenced this issue Sep 28, 2020
@ivucica
Disable hostname resolution in TestEscaping_Error.
0b72882 
The test output does not expect the hostname to be printed; fixing bdlm#28
breaks the test.
ivucica added a commit to ivucica/bdlm-log that referenced this issue Sep 28, 2020
@ivucica
Populate hostname from the OS, not just the environment.
2f357c1 
The environment variable `HOSTNAME` is not necessarily set on a
machine, making a call to `os.Hostname()` a useful replacement.

Fixes bdlm#28.
ivucica added a commit to ivucica/bdlm-log that referenced this issue Sep 28, 2020
@ivucica
Disable hostname resolution in TestEscaping_Error.
5a58529 
The test output does not expect the hostname to be printed; fixing bdlm#28
breaks the test.
@mkenney mkenney closed this as completed in 405434d Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivucica