Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scrollbar] isPointerOverScrollbar() kind parameter #16

Closed
uintdev opened this issue Apr 27, 2021 · 4 comments · Fixed by #35
Closed

[Scrollbar] isPointerOverScrollbar() kind parameter #16

uintdev opened this issue Apr 27, 2021 · 4 comments · Fixed by #35
Assignees
Labels
blocked Issue blocked by another issue or pull-request

Comments

@uintdev
Copy link

uintdev commented Apr 27, 2021

Last month, there was a commit that changes isPointerOverScrollbar() so that it requires an additional parameter for 'kind' (PointerDeviceKind).
As a result, on newer builds of Flutter that has this change (at the time of creating this issue, at least on the dev branch [2.3.0-0.1.pre]), builds will fail due to the expectation of having two parameters rather than one.
flutter/flutter@e02621b#diff-7ea53e627d4729db3a54ab440e8f6d2610cbfc44ac4f9718daef49b2b4645f2dL1177-R1213

@bdlukaa
Copy link
Owner

bdlukaa commented Apr 27, 2021

This commit hasn't landed on stable yet, so I can't update the code since almost all of the devs are on the stable branch (I am too). I don't see a reason for you to use the beta branch tho, since the desktop environment is now supported on the stable branch under an early reklease flag

@bdlukaa bdlukaa added the blocked Issue blocked by another issue or pull-request label Apr 30, 2021
@bdlukaa bdlukaa self-assigned this May 3, 2021
@msoham123
Copy link

@bdlukaa As of Flutter 2.2, on stable branch, I'm receiving the same error. I think the commit might have landed?

@bdlukaa
Copy link
Owner

bdlukaa commented May 20, 2021

@msoham123 The commit hasn't been published to pub.dev yet. Please make sure you're using github's project as dependency:

dependencies:
  fluent_ui:
    git: https://github.com/bdlukaa/fluent_ui.git

Version 2.1.0 will be released at June's 10, 2021 on pub

@msoham123
Copy link

@bdlukaa Ah okay, makes sense. I'll use the github repo instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issue blocked by another issue or pull-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants