Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let numberbox to accept double value #789

Merged
merged 12 commits into from
Mar 28, 2023
Merged

Let numberbox to accept double value #789

merged 12 commits into from
Mar 28, 2023

Conversation

WinXaito
Copy link
Collaborator

@WinXaito WinXaito commented Mar 24, 2023 •
edited
Loading

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@WinXaito WinXaito marked this pull request as draft March 24, 2023 17:41
@WinXaito WinXaito marked this pull request as ready for review March 24, 2023 20:08
@WinXaito WinXaito requested a review from bdlukaa March 24, 2023 20:08
bdlukaa
bdlukaa reviewed Mar 24, 2023
View reviewed changes
Copy link
Owner

@bdlukaa bdlukaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make some methods available, so that it's possible to change the numberbox value programatically using a global key?

lib/src/controls/form/number_box.dart Outdated Show resolved Hide resolved
lib/src/controls/form/number_box.dart Outdated Show resolved Hide resolved
@WinXaito WinXaito mentioned this pull request Mar 25, 2023
Closed
3 tasks
@WinXaito WinXaito requested a review from bdlukaa March 27, 2023 06:33
bdlukaa
bdlukaa reviewed Mar 27, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/controls/form/number_box.dart Show resolved Hide resolved
lib/src/controls/form/number_box.dart Outdated Show resolved Hide resolved
lib/src/controls/form/number_box.dart Outdated Show resolved Hide resolved
@WinXaito WinXaito requested a review from bdlukaa March 28, 2023 16:59
This was linked to issues Mar 28, 2023
Allow NumberBox to work with double value #788
Closed
Min/Max options for NumberBox #787
Closed
@WinXaito WinXaito merged commit eea1563 into bdlukaa:master Mar 28, 2023
@WinXaito WinXaito deleted the numberbox_imp branch March 28, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdlukaa bdlukaa bdlukaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow NumberBox to work with double value Min/Max options for NumberBox
2 participants
@WinXaito @bdlukaa