Add binary sensor to Netatmo (home-assistant#115119)

* Add binary sensor to Netatmo

* Update homeassistant/components/netatmo/binary_sensor.py

Co-authored-by: Jan-Philipp Benecke <github@bnck.me>

* Sigh

* Fix

* Fix

* Fix

---------

Co-authored-by: Jan-Philipp Benecke <github@bnck.me>

homeassistant/components/netatmo/binary_sensor.py

@@ -0,0 +1,60 @@
+"""Support for Netatmo binary sensors."""
+
+from homeassistant.components.binary_sensor import (
+    BinarySensorDeviceClass,
+    BinarySensorEntity,
+    BinarySensorEntityDescription,
+)
+from homeassistant.config_entries import ConfigEntry
+from homeassistant.core import HomeAssistant, callback
+from homeassistant.helpers.dispatcher import async_dispatcher_connect
+from homeassistant.helpers.entity_platform import AddEntitiesCallback
+
+from .const import NETATMO_CREATE_WEATHER_SENSOR
+from .data_handler import NetatmoDevice
+from .entity import NetatmoWeatherModuleEntity
+
+BINARY_SENSOR_TYPES: tuple[BinarySensorEntityDescription, ...] = (
+    BinarySensorEntityDescription(
+        key="reachable",
+        device_class=BinarySensorDeviceClass.CONNECTIVITY,
+    ),
+)
+
+
+async def async_setup_entry(
+    hass: HomeAssistant, entry: ConfigEntry, async_add_entities: AddEntitiesCallback
+) -> None:
+    """Set up Netatmo binary sensors based on a config entry."""
+
+    @callback
+    def _create_weather_binary_sensor_entity(netatmo_device: NetatmoDevice) -> None:
+        async_add_entities(
+            NetatmoWeatherBinarySensor(netatmo_device, description)
+            for description in BINARY_SENSOR_TYPES
+            if description.key in netatmo_device.device.features
+        )
+
+    entry.async_on_unload(
+        async_dispatcher_connect(
+            hass, NETATMO_CREATE_WEATHER_SENSOR, _create_weather_binary_sensor_entity
+        )
+    )
+
+
+class NetatmoWeatherBinarySensor(NetatmoWeatherModuleEntity, BinarySensorEntity):
+    """Implementation of a Netatmo binary sensor."""
+
+    def __init__(
+        self, device: NetatmoDevice, description: BinarySensorEntityDescription
+    ) -> None:
+        """Initialize a Netatmo binary sensor."""
+        super().__init__(device)
+        self.entity_description = description
+        self._attr_unique_id = f"{self.device.entity_id}-{description.key}"
+
+    @callback
+    def async_update_callback(self) -> None:
+        """Update the entity's state."""
+        self._attr_is_on = self.device.reachable
+        self.async_write_ha_state()

homeassistant/components/netatmo/const.py

@@ -9,6 +9,7 @@
 DEFAULT_ATTRIBUTION = f"Data provided by {MANUFACTURER}"
 
 PLATFORMS = [
+    Platform.BINARY_SENSOR,
     Platform.CAMERA,
     Platform.CLIMATE,
     Platform.COVER,

homeassistant/components/netatmo/entity.py

@@ -3,19 +3,21 @@
 from __future__ import annotations
 
 from abc import abstractmethod
-from typing import Any
+from typing import Any, cast
 
 from pyatmo import DeviceType, Home, Module, Room
-from pyatmo.modules.base_class import NetatmoBase
+from pyatmo.modules.base_class import NetatmoBase, Place
 from pyatmo.modules.device_types import DEVICE_DESCRIPTION_MAP
 
+from homeassistant.const import ATTR_LATITUDE, ATTR_LONGITUDE
 from homeassistant.core import callback
 from homeassistant.helpers import device_registry as dr
 from homeassistant.helpers.device_registry import DeviceInfo
 from homeassistant.helpers.entity import Entity
 
 from .const import (
     CONF_URL_ENERGY,
+    CONF_URL_WEATHER,
     DATA_DEVICE_IDS,
     DEFAULT_ATTRIBUTION,
     DOMAIN,
@@ -166,3 +168,39 @@ def __init__(self, device: NetatmoDevice) -> None:
     def device_type(self) -> DeviceType:
         """Return the device type."""
         return self.device.device_type
+
+
+class NetatmoWeatherModuleEntity(NetatmoModuleEntity):
+    """Netatmo weather module entity base class."""
+
+    _attr_configuration_url = CONF_URL_WEATHER
+
+    def __init__(self, device: NetatmoDevice) -> None:
+        """Set up a Netatmo weather module entity."""
+        super().__init__(device)
+        category = getattr(self.device.device_category, "name")
+        self._publishers.extend(
+            [
+                {
+                    "name": category,
+                    SIGNAL_NAME: category,
+                },
+            ]
+        )
+
+        if hasattr(self.device, "place"):
+            place = cast(Place, getattr(self.device, "place"))
+            if hasattr(place, "location") and place.location is not None:
+                self._attr_extra_state_attributes.update(
+                    {
+                        ATTR_LATITUDE: place.location.latitude,
+                        ATTR_LONGITUDE: place.location.longitude,
+                    }
+                )
+
+    @property
+    def device_type(self) -> DeviceType:
+        """Return the Netatmo device type."""
+        if "." not in self.device.device_type:
+            return super().device_type
+        return DeviceType(self.device.device_type.partition(".")[2])

homeassistant/components/netatmo/sensor.py

@@ -8,7 +8,6 @@
 from typing import Any, cast
 
 import pyatmo
-from pyatmo import DeviceType
 from pyatmo.modules import PublicWeatherArea
 
 from homeassistant.components.sensor import (
@@ -48,7 +47,6 @@
 from .const import (
     CONF_URL_ENERGY,
     CONF_URL_PUBLIC_WEATHER,
-    CONF_URL_WEATHER,
     CONF_WEATHER_AREAS,
     DATA_HANDLER,
     DOMAIN,
@@ -59,7 +57,12 @@
     SIGNAL_NAME,
 )
 from .data_handler import HOME, PUBLIC, NetatmoDataHandler, NetatmoDevice, NetatmoRoom
-from .entity import NetatmoBaseEntity, NetatmoModuleEntity, NetatmoRoomEntity
+from .entity import (
+    NetatmoBaseEntity,
+    NetatmoModuleEntity,
+    NetatmoRoomEntity,
+    NetatmoWeatherModuleEntity,
+)
 from .helper import NetatmoArea
 
 _LOGGER = logging.getLogger(__name__)
@@ -491,11 +494,10 @@ async def add_public_entities(update: bool = True) -> None:
     await add_public_entities(False)
 
 
-class NetatmoWeatherSensor(NetatmoModuleEntity, SensorEntity):
+class NetatmoWeatherSensor(NetatmoWeatherModuleEntity, SensorEntity):
     """Implementation of a Netatmo weather/home coach sensor."""
 
     entity_description: NetatmoSensorEntityDescription
-    _attr_configuration_url = CONF_URL_WEATHER
 
     def __init__(
         self,
@@ -506,34 +508,8 @@ def __init__(
         super().__init__(netatmo_device)
         self.entity_description = description
         self._attr_translation_key = description.netatmo_name
-        category = getattr(self.device.device_category, "name")
-        self._publishers.extend(
-            [
-                {
-                    "name": category,
-                    SIGNAL_NAME: category,
-                },
-            ]
-        )
         self._attr_unique_id = f"{self.device.entity_id}-{description.key}"
 
-        if hasattr(self.device, "place"):
-            place = cast(pyatmo.modules.base_class.Place, getattr(self.device, "place"))
-            if hasattr(place, "location") and place.location is not None:
-                self._attr_extra_state_attributes.update(
-                    {
-                        ATTR_LATITUDE: place.location.latitude,
-                        ATTR_LONGITUDE: place.location.longitude,
-                    }
-                )
-
-    @property
-    def device_type(self) -> DeviceType:
-        """Return the Netatmo device type."""
-        if "." not in self.device.device_type:
-            return super().device_type
-        return DeviceType(self.device.device_type.partition(".")[2])
-
     @property
     def available(self) -> bool:
         """Return True if entity is available."""