Use vector for tracking all Setting / Command objects #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchBradley
approved these changes
Jun 29, 2023
Closed
MitchBradley
added a commit
that referenced
this pull request
Jul 13, 2023
This is probably not the best way to fix it, since it uses a GCC-specific feature, vut it works for now.
msxmatt
pushed a commit
to bantamtools/FluidNC
that referenced
this pull request
Jul 13, 2023
This is probably not the best way to fix it, since it uses a GCC-specific feature, vut it works for now.
bdring
added a commit
that referenced
this pull request
Jul 13, 2023
Fix the problems caused by #950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple cleanup, reduces the size of a Setting / Command by one pointer, and allows the use of for-loop iterator sugar.