Invalid Date Exception In active_buses Method #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there is a typo in bus.rb on line 66
time = HrtBus::Parse.time([time, date].join(""))
Resulting data looks like this: 01:35:2603/03
The Parse function is expecting a space in there: DateTime.strptime(data, '%H:%M:%S %m/%d')
Amazingly, this bug didn't break everything all the time. Just didn't work for some data. Adding a space to the join fixes it.