Plaid::LongTailInstitution #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbuckheit be sure to check this! |
| @@ -77,9 +77,116 @@ def self.all | |||
| # | |||
| # Returns an Institution instance or raises Plaid::NotFoundError if | |||
| # institution with given id is not found. | |||
| def self.get(id) | |||
| def self.get!(id) | |||
There was a problem hiding this comment.
i don't see any mutation here, why do we have the !?
There was a problem hiding this comment.
! also means "throws exceptions instead of returning nil". But I decided to ditch this. Most of the gem methods throw exceptions in case of error, we'd need to mark them all with !.
|
just had one question about the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement long tail institution-related API. Everything is in the
Plaid::LongTailInstitutionclass.Also
Plaid::Institution.getwas renamed toPlaid::Institution.get!to stress that it raises an exception if FI was not found. ThePlaid::LongTailInstitution.getreturns nil in this case. This resembles ActiveRecord again, with itsfind_byandfind_by!methods.