Convert Travis to GHA #21
Conversation
|
...i'll fix the test failure on monday. :) |
.github/workflows/CI.yml
Outdated
| matrix: | ||
| version: | ||
| - '1.3' | ||
| - '1' |
There was a problem hiding this comment.
...so the reason this is failing is that we previously supported 1.3 and 1.4, and now we're supporting 1.3 and 1 (...aka 1.5). There's a dependence on a conveniently chosen seeded rng in the tests that (due to intentional/known) differences between rngs across Julia versions causes a failure in 1.5.
The correct ultimate fix is to remove that test dependence on the rng, but that fix is orthogonal to the changes introduced by this PR, so I think a good course of action here is to not change the supported Julia versions here (i.e., revert to 1.3 and 1.4) and then file a separate issue for bumping the supported versions to 1.3 and 1 (which would necessarily require fixing that test).
There was a problem hiding this comment.
...lol, that issue is in fact already filed (as #18).
|
Added a scheduled run every 2 weeks since @hannahilea mentioned that might be a nice thing to have. |
|
Closes #18. |
Closes #18