Deprecate CuIterator in favor of upstream implementation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CuIterator` now lives in CuArrays as of CuArrays 2.0. Flux 0.10.4 and Zygote 0.4.13 added support for CuArrays 2.
jrevels
reviewed
Apr 12, 2020
jrevels
requested changes
Apr 12, 2020
Make the compat bounds stricter to ensure that CuIterator will actually exist in the user's dependencies Co-Authored-By: Jarrett Revels <jarrettrevels@gmail.com>
jrevels
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CuIteratornow lives in CuArrays as of CuArrays 2.0. Flux 0.10.4 and Zygote 0.4.13 added support for CuArrays 2.Fixes #2.