Expose dither_storage as kwarg #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlaberinto
commented
May 11, 2023
kimlaberinto
commented
May 11, 2023
src/import_edf.jl
Outdated
Comment on lines
619
to
620
| `dither_storage` keyword argument is used for `Onda.encode`. See `Onda.encode`'s | ||
| docstring for more details. |
There was a problem hiding this comment.
Wordsmithing welcome here too
|
This PR is ready to review. Keeping it in draft mode in case this isn't the direction we want to proceed with |
palday
approved these changes
May 11, 2023
Co-authored-by: Phillip Alday <palday@users.noreply.github.com>
|
Patch bumped in commit 4d49f95 |
palday
reviewed
May 11, 2023
kleinschmidt
approved these changes
May 11, 2023
|
Not sure if anyone is using OndaEDF on pre-Legolas 0.5 enough to justify backporting things still, but if they are this shoudl be backported... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.