Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial documentation and functionality #1

Merged
merged 27 commits into from
Dec 11, 2020
Merged

Conversation

palday
Copy link
Member

@palday palday commented Dec 7, 2020

Almost everything is delegated to MNE-Python directly, with the exception of create_info, which also serves as an example for how to write override methods.

src/PyMNE.jl Outdated Show resolved Hide resolved
src/PyMNE.jl Show resolved Hide resolved
src/PyMNE.jl Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
src/wrappers.jl Outdated Show resolved Hide resolved
src/wrappers.jl Outdated Show resolved Hide resolved
@ararslan
Copy link
Member

Worth including our set_montage! function? It's handy but doesn't really mimic the MNE interface like the rest of the stuff, so perhaps not in scope for this package.

Co-authored-by: Alex Arslan <ararslan@comcast.net>
@palday
Copy link
Member Author

palday commented Dec 11, 2020

For now, I would leave set_montage! out because it doesn't follow the MNE interface (like you said). I guess it's something we see how users fare -- if we get issues about Montage related functionality failing via the standard PyCall wrapping, then we can add that in. But that is a good point to add to the README -- those types of failures can be raised as issues and potentially added in in future releases.

src/PyMNE.jl Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/PyMNE.jl Show resolved Hide resolved
src/PyMNE.jl Outdated Show resolved Hide resolved
src/wrappers.jl Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
palday and others added 3 commits December 11, 2020 22:55
Co-authored-by: Alex Arslan <ararslan@comcast.net>
@palday palday merged commit bc1a70d into main Dec 11, 2020
@palday palday deleted the pa/initial_functionality branch December 11, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants