Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install MNE via pip #18

Merged
merged 3 commits into from
Aug 8, 2023
Merged

install MNE via pip #18

merged 3 commits into from
Aug 8, 2023

Conversation

palday
Copy link
Member

@palday palday commented May 30, 2023

fixes #17

This was referenced May 30, 2023
Open
Closed
kimlaberinto
kimlaberinto reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@kimlaberinto kimlaberinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and is confirmed to work via: #17 (comment).

One point regarding other changes being moved to another PR if possible. Otherwise 👍

test/runtests.jl Outdated
Comment on lines 15 to 16
# can't use `naive @test_broken` in julia 1.10+ because it now requires a bool
@test_broken (info.ch_names == info["ch_names"]) isa Bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-picky, but could we move this to a different PR as it doesn't pertain to installing MNE via pip?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was mostly done here because without CI was broken to even do the main change, but sure :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see 👍

@kimlaberinto
Copy link
Member

Whoops, I thought I approved it already

@kimlaberinto kimlaberinto mentioned this pull request Aug 8, 2023
Merged
@palday palday merged commit 3cd9321 into main Aug 8, 2023
11 checks passed
@palday palday deleted the pa/depup branch August 8, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlaberinto kimlaberinto kimlaberinto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when loading PyMNE
2 participants
@palday @kimlaberinto