Support TimeSpan construction from Dates.CompoundPeriod, Dates.Period

Project.toml

@@ -1,13 +1,15 @@
 name = "TimeSpans"
 uuid = "bb34ddd2-327f-4c4a-bfb0-c98fc494ece1"
 authors = ["Beacon Biosignals, Inc."]
-version = "0.3.7"
+version = "0.3.8"
 
 [deps]
+Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
 Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 
 [compat]
+Compat = "3.38,4"
 julia = "1.6"
 
 [extras]

src/TimeSpans.jl

@@ -1,6 +1,7 @@
 module TimeSpans
 
 using Base.Iterators
+using Compat
 using Dates
 using Statistics
 
@@ -34,9 +35,13 @@ struct TimeSpan
         start < stop || throw(ArgumentError("start(span) < stop(span) must be true, got $start and $stop"))
         return new(start, stop)
     end
-    TimeSpan(start, stop) = TimeSpan(Nanosecond(start), Nanosecond(stop))
 end
 
+_to_ns(t::Dates.CompoundPeriod) = convert(Nanosecond, t)
+_to_ns(t::Any) = Nanosecond(t)
+
+TimeSpan(start, stop) = TimeSpan(_to_ns(start), _to_ns(stop))
+
 """
     TimeSpan(x)
 

test/runtests.jl

@@ -1,6 +1,8 @@
-using Test, TimeSpans, Dates
-
+using Test
+using TimeSpans
 using TimeSpans: contains, nanoseconds_per_sample
+using Compat
+using Dates
 using Statistics
 
 function naive_index_from_time(sample_rate, sample_time)
@@ -45,6 +47,22 @@ end
     @test translate(t, by) === TimeSpan(start(t) + Nanosecond(by), stop(t) + Nanosecond(by))
     @test translate(t, -by) === TimeSpan(start(t) - Nanosecond(by), stop(t) - Nanosecond(by))
     @test repr(TimeSpan(6149872364198, 123412345678910)) == "TimeSpan(01:42:29.872364198, 34:16:52.345678910)"
+
+    # Periods and compound periods are supported
+    for start in [Nanosecond(3), Minute(1), Minute(3) + Nanosecond(1)]
+        stop = start + Nanosecond(8)
+        start_ns = convert(Nanosecond, start)
+        stop_ns = convert(Nanosecond, stop)
+        @test TimeSpan(start, stop) == TimeSpan(start_ns, stop_ns) == TimeSpan(Dates.value(start_ns), Dates.value(stop_ns))
+    end
+    @test_throws MethodError TimeSpan(now(), now() + Nanosecond(1))
+
+    # Different types for start and stop are supported
+    for (start, stop) in [(3, Nanosecond(8)), (Nanosecond(3), 8), (3, Minute(8))]
+        start_ns = Nanosecond(start)
+        stop_ns = Nanosecond(stop)
+        @test TimeSpan(start, stop) == TimeSpan(start_ns, stop_ns) == TimeSpan(Dates.value(start_ns), Dates.value(stop_ns))
+    end
 end
 
 @testset "format_duration" begin