Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tmt integration #171

Merged
merged 1 commit into from Apr 5, 2024
Merged

fix: tmt integration #171

merged 1 commit into from Apr 5, 2024

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Mar 5, 2024

  • update tmt url reference
  • bump test target to epel-9
  • cleanup packit.yaml file
  • fix test filtering
  • fix tmt plan packages

Depends on teemtee/tmt#2731

@LecrisUT LecrisUT mentioned this pull request Mar 5, 2024
Merged
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 5, 2024 •
edited

/packit test

1 similar comment
@psss
Copy link
Member

psss commented Mar 5, 2024

/packit test

@psss
Copy link
Member

psss commented Mar 6, 2024

All tests green \o/

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 6, 2024 •
edited

👍 I think on this side I just need to drop fbd2d6e after everything is merged? ref: fedora is still intended?

@psss
Copy link
Member

psss commented Mar 6, 2024

👍 I think on this side I just need to drop fbd2d6e after everything is merged?

Yes, once the tmt part is merged.

ref: fedora is still intended?

Good question. For the basic functionality tests should be ok to drop it as well. On the other hand we're testing against the released tmt package in Fedora, so some minor incompatibilities might appear. @lukaszachy, what do you think?

@lukaszachy
Copy link
Contributor

I'd prefer to test against main branch, it has to be stable wrt. beakerlib.

In the future we might remove fedora branch and use distgit/srpm to get test sources instead.

This fedora branch is just a workaround.

@LecrisUT LecrisUT force-pushed the fix/tmt branch 2 times, most recently from 46edc7e to d9b8da5 Compare March 7, 2024 12:18
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 7, 2024

@sopos do you want to cherry-pick 530caf6 onto master? Probably a rebase error sneaked in bc52b42

@sopos
Copy link
Member

sopos commented Mar 7, 2024

@sopos do you want to cherry-pick 530caf6 onto master? Probably a rebase error sneaked in bc52b42

good catch

@LecrisUT
Use upstream's tmt plan
768ad75 
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT LecrisUT force-pushed the fix/tmt branch 2 times, most recently from 0cf0636 to 768ad75 Compare March 22, 2024 08:42
@LecrisUT LecrisUT mentioned this pull request Mar 22, 2024
Merged
3 tasks
@LecrisUT LecrisUT marked this pull request as ready for review March 22, 2024 17:35
@LecrisUT
Copy link
Contributor Author

All ready over here 🙂

psss
psss approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks. @sopos, I guess it's ready for merging?

@sopos sopos merged commit d567137 into beakerlib:master Apr 5, 2024
16 checks passed
@LecrisUT LecrisUT deleted the fix/tmt branch April 5, 2024 09:38
@psss psss mentioned this pull request Apr 10, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LecrisUT @psss @lukaszachy @sopos