Update pre-commit checks and add a couple of new ones

[happz]

Namely prevent commits to main branch, check for merge/rebase conflict markers in files, and look for private keys.

Pull Request Checklist

• implement the feature

[lukaszachy]

I'm surprised no fixup was necessary with checks added.

[martinhoyer]

Security-related checks note:
Skjold doesn't look like being suitable for pre-commit, as it checks .lock or .requirements.txt files.
Perhaps it would could be incorporated to the "without site packages" test.
pyproject.toml:

[tool.skjold]
sources = ["pyup", "gemnasium"] 

$ pip install .[all] skjold
$ pip list --exclude pip --format=freeze | skjold audit -
No vulnerable packages found!

[martinhoyer]

aand I don't see any other suitable (security) pre-commit hooks, so lgtm as is.

[lukaszachy]

aand I don't see any other suitable (security) pre-commit hooks, so lgtm as is.

@martinhoyer btw, could you tick the approval button - that would make github reviews counter happier.

[martinhoyer]

aand I don't see any other suitable (security) pre-commit hooks, so lgtm as is.

@martinhoyer btw, could you tick the approval button - that would make github reviews counter happier.

I'm not a reviewer on this one, so there is no approve button, but I'll keep it in mind for other PRs, thanks!

[psss]

I'm not a reviewer on this one, so there is no approve button, but I'll keep it in mind for other PRs, thanks!

@martinhoyer, I believe, everybody should be able to provide review. Even if not member of the organization / write access to the repo. See my recent review on the beakerlib pull request. You get a gray tick but the review is there.

[psss]

there is no approve button

You go to the Files changed tab and there's the Review changes button.

[martinhoyer]

there is no approve button

You go to the Files changed tab and there's the Review changes button.

Learning every day 🫡 Thanks.
(technically I wasn't wrong about the approve button though hehe)