Fix Stripe.File.create #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
reviewed
May 5, 2024
| @@ -43,7 +43,7 @@ defmodule Stripe.Mixfile do | |||
| defp env do | |||
| [ | |||
| api_base_url: "https://api.stripe.com", | |||
| api_upload_url: "https://files.stripe.com/v1/", | |||
| api_upload_url: "https://files.stripe.com", | |||
There was a problem hiding this comment.
confirmed, we
stripity-stripe/lib/generated/file.ex
Line 142 in 73faf6d
|
CI is failing hhhhmmm |
Seems unrelated to this PR. Also failing in this PR. Error is something to do with the |
|
Would you mind digging into it? Otherwise, I could follow up on by the end of the next week (if I do not forget*) |
|
I'll take a look |
|
Rebase and we go to go |
|
🚀 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Stripe.File.createwas failing/v1//v1/files. This was fixed by changing the config variableapi_upload_url.stripe-mockused not to support it. It does now, so I've enabled the test and fixed it.test/stripe/subscriptions/credit_note_test.exsand it only involves the order of query parameters. Hopefully this fix is stable.