fix various problems breaking CI #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aymanosman
commented
May 6, 2024
aymanosman
commented
- erlexec requires SHELL env var to be set
- erlexec requires its user option to be set to "root" when run as root (which is - the case in CI)
- a couple of tests are sensitive to the order query parameters are encoded
- erlexec requires SHELL env var to be set - erlexec requires its user option to be set to "root" when run as root (which is - the case in CI) - a couple of tests are sensitive to the order query parameters are encoded
Merged
|
Might want to run |
|
Also, thanks for helping get our PRs unstuck, @aymanosman! 🙌 |
|
Thank you folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.