fixes 3326 #3338
Merged
fixes 3326 #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielbeamable
approved these changes
Apr 24, 2024
allister-beamable
requested changes
Apr 24, 2024
| id = "test", | ||
| name = "test", | ||
| owner = "test", | ||
| source = new OptionalString(), |
There was a problem hiding this comment.
The semantics here are that new OptionalString() with no constructor argument is an empty optional string? That is, new OptionalString() is the equivalent of Scalas None`?
There was a problem hiding this comment.
correct- that is a None
| @@ -6,12 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [1.19.18] | |||
| ### Fixed | |||
| - `BeamScheduler` can deserialize jobs without a `source` field. | |||
| - `AssumeNewUser` does not allow `userId` that is not a positive value | |||
There was a problem hiding this comment.
This seems not-relevant to the current changes.
There was a problem hiding this comment.
nvm, I'm bad at reading diffs. I wish GitHub had highlighted it differently.
allister-beamable
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes 3326 by not throwing exception if source doesn't exist.