-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes 3326 #3338
fixes 3326 #3338
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
using Beamable.Api.Autogenerated.Models; | ||
using Beamable.Common.Content; | ||
using Beamable.Common.Scheduler; | ||
using NUnit.Framework; | ||
|
||
namespace microserviceTests.CronBuilderTests; | ||
|
||
public class JobConversionTests : CommonTest | ||
{ | ||
[TestCase] | ||
public void CanDeserializeJobWithoutSource() | ||
{ | ||
var job = new JobDefinition | ||
{ | ||
id = "test", | ||
name = "test", | ||
owner = "test", | ||
source = new OptionalString(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The semantics here are that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. correct- that is a |
||
jobAction = new HttpCall | ||
{ | ||
body = "test", | ||
contentType = "test", | ||
method = "post", | ||
uri = "test" | ||
}, | ||
retryPolicy = new OptionalJobRetryPolicy(new JobRetryPolicy | ||
{ | ||
maxRetryCount = 1, | ||
retryDelayMs = 1, | ||
useExponentialBackoff = false | ||
}), | ||
triggers = new IOneOf_CronTriggerOrExactTrigger[]{} | ||
}; | ||
|
||
var result = BeamScheduler.Utility.Convert(job); | ||
Assert.That(result.source, Is.Null); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems not-relevant to the current changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, I'm bad at reading diffs. I wish GitHub had highlighted it differently.