Site Summary Window #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Password corruption BE-5220 See merge request beamgroup/beam!3718
Cherry Pick "Fix first sync after login shouldn't block the UI BE-5597" into develop See merge request beamgroup/beam!3735
…ing full sync (MR for beta-0.16.0) BE-5595" into develop
Cherry Pick "On \"slow\" network, download from s3 fails randomly during full sync (MR for beta-0.16.0) BE-5595" into develop See merge request beamgroup/beam!3736
…into 'develop' Fix slack notif syntax when cherry pick fail - BE-5602 See merge request beamgroup/beam!3737
Set size and position of the app to a default in the clean up - BE-5560 See merge request beamgroup/beam!3734
…all' into 'develop' Refactor UIMenu to call UITestMenuAvailableCommands with single method - BE-5565 See merge request beamgroup/beam!3714
…into 'develop' Await existing full sync if needed, BE-5588 See merge request beamgroup/beam!3727
…Note/Web/Note" into develop
Cherry Pick "Link of image is going out of the screen when switching Note/Web/Note" into develop See merge request beamgroup/beam!3739
Rework CI to use only needed before script and save only needed artefacts - BE-5594 See merge request beamgroup/beam!3729
Feature Go to tab (if it is already open) BE-209 See merge request beamgroup/beam!3692
…g' into 'develop' Implement global setUp for E2E tests - BE-5574 See merge request beamgroup/beam!3715
…lop' Video side call window feature - BE-4160 BE-4161 See merge request beamgroup/beam!3701
Fix tests flakiness See merge request beamgroup/beam!3743
… 'develop' Fix thread-safety issue on changedObjects, BE-5262 See merge request beamgroup/beam!3741
Video side call window management - BE-4162 See merge request beamgroup/beam!3742
…to 'develop' Avoid logging errors when not authenticated or no network is available, BE-4789 See merge request beamgroup/beam!3747
Simplified Onboarding, BE-5649 See merge request beamgroup/beam!3854
Make SyncTests faster by not syncing the onboarding notes See merge request beamgroup/beam!3864
…to 'develop' Check that note frecencies are deleted when notes are deleted BE 4853 See merge request beamgroup/beam!3780
Disable Point and Shoot for Google services BE-4937 See merge request beamgroup/beam!3865
Cherry Pick "Fix drag and drop between two editors" into develop See merge request beamgroup/beam!3867
Commit JavaScript build files
…disable js build all the time
Remove any notion of variable-injector
Remove any notion of firebase
Fix app target debug build
Remove Sentry fixes: #10
remstos
reviewed
Oct 24, 2023
| .background(GeometryReader { proxy -> Color in | ||
| let rect = proxy.safeTopLeftGlobalFrame(in: nil) | ||
| let center = CGPoint(x: rect.origin.x + rect.width / 2, y: rect.origin.y + rect.height / 2) | ||
| state.summaryButtonPosition = center |
There was a problem hiding this comment.
Is it me or summaryButtonPosition is never used ?
There was a problem hiding this comment.
Yeah I converted this from the download button situation
also I should hide the button when there is no summary available
still testing btw about the usefulness, as usual the results are hit and miss 😅
There was a problem hiding this comment.
yeah that’s a good POC 👍 for sure could be more styled and have more conditions on when to display it
|
I don’t know where is the approve button, but approved 👍 haha |
remstos
force-pushed
the
main
branch
2 times, most recently
from
9cab908
to
59aa743
Compare
|
I messed up the repo by removing the lfs files so you might close and reopen 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goofing around with the built in summary tool