Skip to content

Commit

Permalink
Functions don't need to pass in constant values, remove to keep codin…
Browse files Browse the repository at this point in the history
…g style similar
  • Loading branch information
beandog committed May 30, 2019
1 parent 9e84d8d commit caebefb
Show file tree
Hide file tree
Showing 8 changed files with 34 additions and 34 deletions.
12 changes: 6 additions & 6 deletions bluray_audio.c
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
#include "bluray_audio.h"

void bluray_audio_lang(char *str, const uint8_t lang[BLURAY_INFO_AUDIO_LANG_STRLEN]) {
void bluray_audio_lang(char *str, uint8_t lang[BLURAY_INFO_AUDIO_LANG_STRLEN]) {

memset(str, '\0', BLURAY_INFO_AUDIO_LANG_STRLEN);
memcpy(str, lang, BLURAY_INFO_AUDIO_LANG_STRLEN - 1);

}

void bluray_audio_codec(char *str, const uint8_t coding_type) {
void bluray_audio_codec(char *str, uint8_t coding_type) {

memset(str, '\0', BLURAY_INFO_AUDIO_CODEC_STRLEN);

Expand Down Expand Up @@ -55,7 +55,7 @@ void bluray_audio_codec(char *str, const uint8_t coding_type) {

}

void bluray_audio_codec_name(char *str, const uint8_t coding_type) {
void bluray_audio_codec_name(char *str, uint8_t coding_type) {

memset(str, '\0', BLURAY_INFO_AUDIO_CODEC_NAME_STRLEN);

Expand Down Expand Up @@ -103,7 +103,7 @@ void bluray_audio_codec_name(char *str, const uint8_t coding_type) {

}

bool bluray_audio_secondary_stream(const uint8_t coding_type) {
bool bluray_audio_secondary_stream(uint8_t coding_type) {

if(coding_type == BLURAY_STREAM_TYPE_AUDIO_AC3PLUS_SECONDARY || coding_type == BLURAY_STREAM_TYPE_AUDIO_DTSHD_SECONDARY)
return true;
Expand All @@ -112,7 +112,7 @@ bool bluray_audio_secondary_stream(const uint8_t coding_type) {

}

void bluray_audio_format(char *str, const uint8_t format) {
void bluray_audio_format(char *str, uint8_t format) {

memset(str, '\0', BLURAY_INFO_AUDIO_FORMAT_STRLEN);

Expand All @@ -138,7 +138,7 @@ void bluray_audio_format(char *str, const uint8_t format) {

}

void bluray_audio_rate(char *str, const uint8_t rate) {
void bluray_audio_rate(char *str, uint8_t rate) {

memset(str, '\0', BLURAY_INFO_AUDIO_RATE_STRLEN);

Expand Down
12 changes: 6 additions & 6 deletions bluray_audio.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,16 @@ struct bluray_audio {
char rate[BLURAY_INFO_AUDIO_RATE_STRLEN];
};

void bluray_audio_lang(char *str, const uint8_t lang[BLURAY_INFO_AUDIO_LANG_STRLEN]);
void bluray_audio_lang(char *str, uint8_t lang[BLURAY_INFO_AUDIO_LANG_STRLEN]);

void bluray_audio_codec(char *str, const uint8_t coding_type);
void bluray_audio_codec(char *str, uint8_t coding_type);

void bluray_audio_codec_name(char *str, const uint8_t coding_type);
void bluray_audio_codec_name(char *str, uint8_t coding_type);

bool bluray_audio_secondary_stream(const uint8_t coding_type);
bool bluray_audio_secondary_stream(uint8_t coding_type);

void bluray_audio_format(char *str, const uint8_t aspect);
void bluray_audio_format(char *str, uint8_t aspect);

void bluray_audio_rate(char *str, const uint8_t rate);
void bluray_audio_rate(char *str, uint8_t rate);

#endif
2 changes: 1 addition & 1 deletion bluray_pgs.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "bluray_pgs.h"

void bluray_pgs_lang(char *str, const uint8_t lang[BLURAY_PGS_LANG_STRLEN]) {
void bluray_pgs_lang(char *str, uint8_t lang[BLURAY_PGS_LANG_STRLEN]) {

memset(str, '\0', BLURAY_PGS_LANG_STRLEN);
memcpy(str, lang, BLURAY_PGS_LANG_STRLEN - 1);
Expand Down
2 changes: 1 addition & 1 deletion bluray_pgs.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ struct bluray_pgs {
char lang[BLURAY_PGS_LANG_STRLEN];
};

void bluray_pgs_lang(char *str, const uint8_t lang[BLURAY_PGS_LANG_STRLEN]);
void bluray_pgs_lang(char *str, uint8_t lang[BLURAY_PGS_LANG_STRLEN]);

#endif
10 changes: 5 additions & 5 deletions bluray_time.c
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#include "bluray_time.h"

uint64_t bluray_duration_seconds(const uint64_t duration) {
uint64_t bluray_duration_seconds(uint64_t duration) {

uint64_t seconds = duration / 90000;

return seconds;

}

uint64_t bluray_duration_minutes(const uint64_t duration) {
uint64_t bluray_duration_minutes(uint64_t duration) {

uint64_t seconds = duration / 90000;
uint64_t minutes = seconds / 60;
Expand All @@ -17,7 +17,7 @@ uint64_t bluray_duration_minutes(const uint64_t duration) {

}

void bluray_duration_length(char *str, const uint64_t duration) {
void bluray_duration_length(char *str, uint64_t duration) {

uint64_t msecs = duration / 90000;
uint64_t d_hours = msecs / 3600;
Expand All @@ -29,7 +29,7 @@ void bluray_duration_length(char *str, const uint64_t duration) {

}

uint64_t bluray_chapter_duration(struct bluray *bd, const uint32_t title_ix, const uint32_t chapter_ix, const uint8_t angle_ix) {
uint64_t bluray_chapter_duration(struct bluray *bd, uint32_t title_ix, uint32_t chapter_ix, uint8_t angle_ix) {

int retval = 0;
retval = bd_select_title(bd, title_ix);
Expand Down Expand Up @@ -61,7 +61,7 @@ uint64_t bluray_chapter_duration(struct bluray *bd, const uint32_t title_ix, con

}

void bluray_chapter_length(char *dest_str, struct bluray *bd, const uint32_t title_ix, const uint32_t chapter_ix, const uint8_t angle_ix) {
void bluray_chapter_length(char *dest_str, struct bluray *bd, uint32_t title_ix, uint32_t chapter_ix, uint8_t angle_ix) {

uint64_t duration = 0;

Expand Down
10 changes: 5 additions & 5 deletions bluray_time.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
#include <inttypes.h>
#include "libbluray/bluray.h"

uint64_t bluray_duration_seconds(const uint64_t duration);
uint64_t bluray_duration_seconds(uint64_t duration);

uint64_t bluray_duration_minutes(const uint64_t duration);
uint64_t bluray_duration_minutes(uint64_t duration);

void bluray_duration_length(char *str, const uint64_t duration);
void bluray_duration_length(char *str, uint64_t duration);

uint64_t bluray_chapter_duration(struct bluray *bd, const uint32_t title_ix, const uint32_t chapter_ix, const uint8_t angle_ix);
uint64_t bluray_chapter_duration(struct bluray *bd, uint32_t title_ix, uint32_t chapter_ix, uint8_t angle_ix);

void bluray_chapter_length(char *dest_str, struct bluray *bd, const uint32_t title_ix, const uint32_t chapter_ix, const uint8_t angle_ix);
void bluray_chapter_length(char *dest_str, struct bluray *bd, uint32_t title_ix, uint32_t chapter_ix, uint8_t angle_ix);

#endif
10 changes: 5 additions & 5 deletions bluray_video.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "bluray_video.h"

void bluray_video_codec(char *str, const uint8_t coding_type) {
void bluray_video_codec(char *str, uint8_t coding_type) {

memset(str, '\0', BLURAY_INFO_VIDEO_CODEC_STRLEN);

Expand Down Expand Up @@ -32,7 +32,7 @@ void bluray_video_codec(char *str, const uint8_t coding_type) {

}

void bluray_video_codec_name(char *str, const uint8_t coding_type) {
void bluray_video_codec_name(char *str, uint8_t coding_type) {

memset(str, '\0', BLURAY_INFO_VIDEO_CODEC_NAME_STRLEN);

Expand Down Expand Up @@ -64,7 +64,7 @@ void bluray_video_codec_name(char *str, const uint8_t coding_type) {

}

void bluray_video_format(char *str, const uint8_t format) {
void bluray_video_format(char *str, uint8_t format) {

memset(str, '\0', BLURAY_INFO_VIDEO_FORMAT_STRLEN);

Expand Down Expand Up @@ -108,7 +108,7 @@ void bluray_video_format(char *str, const uint8_t format) {

}

double bluray_video_framerate(const uint8_t rate) {
double bluray_video_framerate(uint8_t rate) {

switch(rate) {

Expand Down Expand Up @@ -137,7 +137,7 @@ double bluray_video_framerate(const uint8_t rate) {

}

void bluray_video_aspect_ratio(char *str, const uint8_t aspect) {
void bluray_video_aspect_ratio(char *str, uint8_t aspect) {

memset(str, '\0', BLURAY_INFO_VIDEO_ASPECT_RATIO_STRLEN);

Expand Down
10 changes: 5 additions & 5 deletions bluray_video.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ struct bluray_video {
char aspect_ratio[BLURAY_INFO_VIDEO_ASPECT_RATIO_STRLEN];
};

void bluray_video_codec(char *str, const uint8_t coding_type);
void bluray_video_codec(char *str, uint8_t coding_type);

void bluray_video_codec_name(char *str, const uint8_t coding_type);
void bluray_video_codec_name(char *str, uint8_t coding_type);

void bluray_video_format(char *str, const uint8_t format);
void bluray_video_format(char *str, uint8_t format);

double bluray_video_framerate(const uint8_t rate);
double bluray_video_framerate(uint8_t rate);

void bluray_video_aspect_ratio(char *str, const uint8_t aspect);
void bluray_video_aspect_ratio(char *str, uint8_t aspect);

#endif

0 comments on commit caebefb

Please sign in to comment.