printing int64 on different archs #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This has actually been fixed in the upstream source of ct. The best way to fix this is to update to the newest version. |
|
@kr How about release new version? |
@sergeyklay Please track #383. |
| @@ -14,6 +14,7 @@ | |||
| #include <errno.h> | |||
| #include <sys/time.h> | |||
| #include <stdint.h> | |||
| #include <inttypes.h> | |||
There was a problem hiding this comment.
Minor comment. I'd add something like:
#ifndef PRId64
#error "Need definition for PRId64 but not provided by <stdint.h>"
#endif
There was a problem hiding this comment.
Oops, missed that a similar fix was merged as part of a different commit...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are warnings about size mis-matches. Including inttypes.h and using the constant fixes the issue so that the print format is the same regardless of x86_64 or i686.