bug(date3): rely on comparison of hour and year strings but not strict char position #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
…t char position Which cause certain strings with format like "MM DD, YYxx xx:SS" parsed incorrectly. See bear#137
philiptzou
force-pushed
the
pull-request-date3-string-comparison
branch
from
e528d27
to
73b4542
Compare
|
nice fix, and with tests! woo! |
bear
added a commit
that referenced
this pull request
Nov 2, 2015
…parison bug(date3): rely on comparison of hour and year strings but not strict char position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which cause certain strings with format like "MM DD, YYxx xx:SS" parsed incorrectly.
See #137