fix "ass" being interpreted as a time #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, honestly this issue is immediately top of the list for "Most Amusing Bug of 2016". We were puzzled as to why our app was behaving incorrectly whenever the word "ass" was used in a sentence. We soon found that parsedatetime is treating "ass" as a time:
We tracked the issue down to a curious QUNITS regular expression which matches the word "a" as the number 1, the letter "s", and then another "s" for "seconds" (it would also match the word "ash" via the same logic with "hours"). We couldn't quite make sense of the second "s" in the regular expression and believe it should have been "\s" instead - making that change fixes the issue.
This PR also fixes a time-sensitive spec that started failing a couple of days ago.
cc @bgalbraith
This change is