Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makefile for use with pypy and 64 bit linux. #379

Merged
merged 5 commits into from
Sep 14, 2016
Merged

Conversation

jeremylow
Copy link
Collaborator

@jeremylow jeremylow commented Aug 5, 2016

Description

Changes the makefile to get the uname -m (returning either "i686" for 32-bit systems or "x86_64" for 64-bit systems) and uname -s (returning "Linux" at least on Ubuntu and Arch) and, if it's "x86_64" & "Linux", then use the source distribution of pypy-5.3.

Related Issue

#378

Motivation and Context

Running make dev on a 64-bit Linux system results in failure to install pypy-5.3, since only pypy-5.3-src is available for 64-linux.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • All new and existing tests passed.

This change is Reviewable

@jeremylow
Copy link
Collaborator Author

Build is failing on make dev trying to build pypy-5.3-src from source, which would slow down builds considerably.

pyenv install -s 2.7.11
pyenv install -s 3.5.2
Downloading Python-3.5.2.tar.xz...
-> https://www.python.org/ftp/python/3.5.2/Python-3.5.2.tar.xz
Installing Python-3.5.2...
Installed Python-3.5.2 to /opt/circleci/.pyenv/versions/3.5.2

pyenv install -s pypy-5.3-src
pyenv-install: pypy-5.3-src: PyPy requires `curses' in 2.7.11 to build from source.
make: *** [dev] Error 1

make dev returned exit code 2

Action failed: make dev

@bear
Copy link
Owner

bear commented Aug 5, 2016

we could adopt a policy of supporting versions of pypy that have binary distributions and bump the version to 5.2?

@jeremylow
Copy link
Collaborator Author

Another option is to have the make ci target be explicit about the versions to use and have the make dev target take into account the user's machine. Right now, it looks like the pyenv versions available on the CI machines are 3.5.1 and 2.7.11. When we changed that from 3.5.1 to 3.5.2, we started downloading and installing a new version of 3.5.2 each time we ran a build. I'd be OK with either mirroring what's available on CircleCI or sticking to binary versions.

@bear
Copy link
Owner

bear commented Aug 10, 2016

My goal for doing that was to have CI be against the most recent versions, but i'm for your plan

@bear
Copy link
Owner

bear commented Sep 13, 2016

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@jeremylow
Copy link
Collaborator Author

Finally! That's a niffy ssh feature, @bear. So at the moment our CI is a little behind relative to cutting edge versions of python/pypy, but we've got tests running across all major versions, so I think that works for me.

@bear
Copy link
Owner

bear commented Sep 14, 2016

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bear
Copy link
Owner

bear commented Sep 14, 2016

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jeremylow jeremylow merged commit c69fc16 into master Sep 14, 2016
@jeremylow jeremylow deleted the fix/issue378 branch September 14, 2016 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants