-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update makefile for use with pypy and 64 bit linux. #379
Conversation
Build is failing on
|
we could adopt a policy of supporting versions of pypy that have binary distributions and bump the version to 5.2? |
Another option is to have the |
My goal for doing that was to have CI be against the most recent versions, but i'm for your plan |
Reviewed 1 of 1 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Finally! That's a niffy ssh feature, @bear. So at the moment our CI is a little behind relative to cutting edge versions of python/pypy, but we've got tests running across all major versions, so I think that works for me. |
Reviewed 1 of 1 files at r3. Comments from Reviewable |
Reviewed 1 of 1 files at r3. Comments from Reviewable |
Description
Changes the
makefile
to get theuname -m
(returning either "i686" for 32-bit systems or "x86_64" for 64-bit systems) anduname -s
(returning "Linux" at least on Ubuntu and Arch) and, if it's "x86_64" & "Linux", then use the source distribution of pypy-5.3.Related Issue
#378
Motivation and Context
Running
make dev
on a 64-bit Linux system results in failure to install pypy-5.3, since only pypy-5.3-src is available for 64-linux.Types of changes
Checklist:
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)