Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added param return_json (bool, optional): #501

Merged
merged 1 commit into from Sep 2, 2017
Merged

Conversation

ganti
Copy link
Contributor

@ganti ganti commented Sep 2, 2017

I felt the need to dump sometimes the JSON stream instead of the object twitter.User
By default this feature is not active.

Also, if this pull request is accepted the tests might need an update, haven't touched those yet.


This change is Reviewable

If True JSON data will be returned, instead of twitter.User
@bear
Copy link
Owner

bear commented Sep 2, 2017

not sure how I feel about adding yet another parameter for this, but willing to give it a try until someone explains why it's such a bad idea.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bear bear merged commit c8cf69c into bear:master Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants