Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recvmsg to handle/ignore control messages when poll_read fails #26

Closed
wants to merge 10 commits into from

Conversation

fasterthanlime
Copy link
Contributor

@fasterthanlime fasterthanlime commented Jun 29, 2023

Alternative to #25.

This is blocked on nix-rust/nix#2065 + a nix crate release.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (7c377ca) 76.68% compared to head (81ebfcd) 74.81%.

❗ Current head 81ebfcd differs from pull request most recent head f69d70d. Consider uploading reports for the commit f69d70d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   76.68%   74.81%   -1.88%     
==========================================
  Files           4        5       +1     
  Lines         476      528      +52     
==========================================
+ Hits          365      395      +30     
- Misses        111      133      +22     
Files Coverage Δ
src/lib.rs 94.40% <100.00%> (ø)
src/async_read_ready.rs 0.00% <0.00%> (ø)
src/cork_stream.rs 79.83% <50.00%> (-4.24%) ⬇️
src/ktls_stream.rs 61.86% <72.34%> (+4.53%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasterthanlime
Copy link
Contributor Author

Closed in favor of #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant