Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to recvmsg #25

Closed
wants to merge 9 commits into from
Closed

Switch to recvmsg #25

wants to merge 9 commits into from

Conversation

fasterthanlime
Copy link
Collaborator

cf. #24

@fasterthanlime
Copy link
Collaborator Author

fasterthanlime commented Jun 14, 2023

In the new, recvmsg codepath, this is what I see when tickets are sent:

 2023-06-14T11:03:41.858232Z TRACE ktls::ktls_stream: recvmsg result = Ok(
    RecvMsg {
        bytes: 81,
        cmsghdr: Some(
            cmsghdr {
                cmsg_len: 17,
                cmsg_level: 282,
                cmsg_type: 2,
            },
        ),
        address: Some(
            SockaddrIn(
                sockaddr_in {
                    sin_family: 63760,
                    sin_port: 13328,
                    sin_addr: in_addr {
                        s_addr: 32713,
                    },
                    sin_zero: [
                        0,
                        0,
                        4,
                        0,
                        0,
                        0,
                        0,
                        0,
                    ],
                },
            ),
        ),
        flags: MSG_EOR,
        iobufs: PhantomData<&()>,
        mhdr: msghdr {
            msg_name: 0x00007fc9387f1af0,
            msg_namelen: 0,
            msg_iov: 0x00007fc9387f2950,
            msg_iovlen: 1,
            msg_control: 0x00007fc93401efa0,
            msg_controllen: 24,
            msg_flags: 128,
        },
    },
)
    at src/ktls_stream.rs:113

Vs when they're not sent:

RecvMsg {
    bytes: 49152,
    cmsghdr: Some(
        cmsghdr {
            cmsg_len: 17,
            cmsg_level: 282,
            cmsg_type: 2,
        },
    ),
    address: Some(
        SockaddrIn(
            sockaddr_in {
                sin_family: 63760,
                sin_port: 16400,
                sin_addr: in_addr {
                    s_addr: 32523,
                },
                sin_zero: [
                    0,
                    0,
                    4,
                    0,
                    0,
                    0,
                    0,
                    0,
                ],
            },
        ),
    ),
    flags: MSG_EOR,
    iobufs: PhantomData<&()>,
    mhdr: msghdr {
        msg_name: 0x00007f0b44bf16d0,
        msg_namelen: 0,
        msg_iov: 0x00007f0b44bf25d0,
        msg_iovlen: 1,
        msg_control: 0x00007f0b40010b50,
        msg_controllen: 24,
        msg_flags: 128,
    },
}

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #25 (a5aeedd) into main (c6d79c1) will decrease coverage by 1.08%.
The diff coverage is 68.62%.

❗ Current head a5aeedd differs from pull request most recent head a04fa88. Consider uploading reports for the commit a04fa88 to get more accurate results

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   77.05%   75.97%   -1.08%     
==========================================
  Files           4        5       +1     
  Lines         475      512      +37     
==========================================
+ Hits          366      389      +23     
- Misses        109      123      +14     
Impacted Files Coverage Δ
src/async_read_ready.rs 0.00% <0.00%> (ø)
src/cork_stream.rs 79.83% <50.00%> (-4.24%) ⬇️
src/ktls_stream.rs 64.07% <83.87%> (+6.74%) ⬆️
src/lib.rs 94.44% <100.00%> (ø)

@fasterthanlime fasterthanlime changed the title Start switching to recvmsg Switch to recvmsg Jun 29, 2023
@fasterthanlime
Copy link
Collaborator Author

Closing in favor of #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant