Get access to message payload #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teivah
requested review from
cpapidas,
drakos74,
fpapadopou,
mantzas,
moukoublen and
sotirispl
as code owners
teivah
commented
May 13, 2020
| // Nack signals the producing side an erroring condition or inconsistency. | ||
| func (m *message) Nack() error { | ||
| messageConfirmationCountInc("NACK") | ||
| trace.SpanError(m.span) | ||
| return nil | ||
| } | ||
|
|
||
| // Source returns the kafka topic where the message arrived. | ||
| func (m *message) Source() string { |
There was a problem hiding this comment.
I just swapped Source() and Nack() so that we have the same order in all the implem & the interface
drakos74
previously approved these changes
May 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 84.48% 84.38% -0.11%
==========================================
Files 52 52
Lines 3074 3099 +25
==========================================
+ Hits 2597 2615 +18
- Misses 398 402 +4
- Partials 79 82 +3
Continue to review full report at Codecov.
|
mantzas
requested changes
May 13, 2020
mantzas
approved these changes
May 14, 2020
drakos74
approved these changes
May 14, 2020
fpapadopou
approved these changes
May 14, 2020
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210.